From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8AFD915E5BB; Sun, 23 Nov 2025 10:23:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763893399; cv=none; b=qn50MelMx+9QbXKUI7SjA1pAZh77VLDRGJbfu0w15ROTGN0VTZHChl6DJaDvgs8qg7AQZs3yuYfQXa9HYE3gC+rhjwI4Ni3JmlE87NNF4rqAT3jGjAGLOvz9If50fEEufluORcZ107kDDeFSJfaLz0LDRhGz8zsodlRey8p0gTQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763893399; c=relaxed/simple; bh=UiX7HVf3vaYnrjH0z8zCjrfqBr/dzzXW1fZ0kqi45VM=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=FWtgH2j2Yd7ZD5jV4eWn7NAagD3qKLhB2iaUZHmvIVQKAF81t254gOMz+s5efba+0pYzbchIVeAE6fLLONHvb4X2im6Qfrko8RX0PJmhhuJtXUjCKow+x/sDBJZ+H2Cw8cJEAwZ2jgV52xnLcPCxEqiZnZGq3Vkh5iriDDOaL1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tarun4EM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tarun4EM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5D90C113D0; Sun, 23 Nov 2025 10:23:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1763893399; bh=UiX7HVf3vaYnrjH0z8zCjrfqBr/dzzXW1fZ0kqi45VM=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=Tarun4EMLm/3AZKunWxcyKCAkMOWd8a/zIZbPLFSEioDD/m45BkNjFJ3Fd1r75o/y p5kS+YGd29OaLc6tXGR/yb0twr4ByhhFFWg0KX7mqUZpJ9Lu+LjPz6sPCbKZ+L36Xh zR0CjOMNi3i8wIwq+p+1kV+q0UDGw3ask4WsCugsoJQ4XlncTQ+zuPvXyD+NH3B6D0 XzeeW1CILUZ+BZmbjxLtLPJhH01rvfsSsUcpryW0/arA81mSdItlbcA7hgnBXFwkaz WqYPdfEkDda1OsYR3YVIktGbjG4XeRqsDaCKN/ogUGc5no/qM6jpJWXzFqN5X8yr4I NzY8qbUoIwkdg== Message-ID: Date: Sun, 23 Nov 2025 11:23:12 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/2] arm64: dts: add support for NXP i.MX8MP FRDM board From: Krzysztof Kozlowski To: Rogerio Pimentel , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de Cc: kernel@pengutronix.de, festevam@gmail.com, alexander.stein@ew.tq-group.com, dario.binacchi@amarulasolutions.com, marex@denx.de, Markus.Niebel@tq-group.com, y.moog@phytec.de, joao.goncalves@toradex.com, frieder.schrempf@kontron.de, josua@solid-run.com, francesco.dolcini@toradex.com, primoz.fiser@norik.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Xiaofeng Wei , Joseph Guo , Steven Yang , Lei Xu References: <20251123003603.246399-1-rpimentel.silva@gmail.com> <20251123003603.246399-2-rpimentel.silva@gmail.com> <7e50c694-af6b-40cc-b1dc-4dd4ecf85a8d@kernel.org> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <7e50c694-af6b-40cc-b1dc-4dd4ecf85a8d@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23/11/2025 10:42, Krzysztof Kozlowski wrote: > On 23/11/2025 01:36, Rogerio Pimentel wrote: >> The FRDM-i.MX8MP is an NXP development platform based on the i.MX8M Plus >> SoC, featuring a quad Cortex-A53, Cortex-M7 co-processor, 4GB LPDDR4, >> 32GB eMMC, Wi-Fi 6/Bluetooth 5.4/802.15.4 tri-radio, Ethernet, HDMI/MIPI >> display interfaces, camera connectors, and standard expansion headers. >> >> Based on the device tree found in the NXP repository at github >> https://github.com/nxp-imx-support/meta-imx-frdm and on imx8mp-evk >> board kernel mainline device tree. >> >> This is a basic device tree supporting: >> >> - Quad Cortex-A53 >> - 4GB LPDDR4 DRAM >> - PCA9450C PMIC with regulators >> - Two NXP PCAL6416 GPIO expanders >> - RGB LEDs via GPIO expander >> - I2C1, I2C2, I2C3 controllers >> - UART2 (console) and UART3 (with RTS/CTS) >> - USDHC3 (8-bit eMMC) >> - SNVS power key (onboard power button) >> >> Author: Xiaofeng Wei > > There is no such tag. Use git commit --amend --reset-author to set the > author. > >> Signed-off-by: Xiaofeng Wei >> >> Co-developed-by: Joseph Guo >> Signed-off-by: Joseph Guo >> > > There is never blank line between tags. > >> Co-developed-by: Steven Yang >> Signed-off-by: Steven Yang >> >> Co-developed-by: Lei Xu >> Signed-off-by: Lei Xu >> >> Co-developed-by: Rogerio Pimentel >> Signed-off-by: Rogerio Pimentel >> --- >> >> Changes in v5: >> >> - Replace underscores (_) in node names with dashes (-) >> - Added missing Co-developed-by and Signed-off-by tags from all contributors > > I assume you actually saw these SoBs in the code you took as your base? > Remember, do not add SoBs which were never present in the original work > (if company asks you, you can politely reply that they need to read what > SoB means) > > That's anyway weirdly a lot of co-developed tags, are you sure they > wrote the code you took as the base here? Although I think you mentioned you wanted all these last time, so it's fine. Although I did not think you will literally use that syntax and literally all the tags from Daniel's responses, because the syntax was not correct. Best regards, Krzysztof