From: Markus Elfring <Markus.Elfring@web.de>
To: Leo Yan <leo.yan@arm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Anshuman Khandual <anshuman.khandual@arm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
James Clark <james.clark@linaro.org>,
Mike Leach <mike.leach@linaro.org>,
Suzuki Poulouse <suzuki.poulose@arm.com>,
Tamas Zsoldos <tamas.zsoldos@arm.com>
Subject: Re: [PATCH v2] coresight: trbe: Return NULL pointer for allocation failures
Date: Thu, 4 Sep 2025 18:10:45 +0200 [thread overview]
Message-ID: <b8dd23cd-9e95-4e2c-8388-54b6d184bcf2@web.de> (raw)
In-Reply-To: <20250904-cs_etm_auxsetup_fix_error_handling-v2-1-a502d0bafb95@arm.com>
…
> Fix this by returning a NULL pointer from arm_trbe_alloc_buffer() on
> allocation failures. This allows that the callers can properly handle
> the failure.
See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc4#n94
By the way:
* Would you like to improve the exception handling by using a goto chain?
* How do you think about to increase the application of scope-based resource management?
https://elixir.bootlin.com/linux/v6.17-rc4/source/include/linux/slab.h#L476
Regards,
Markus
next prev parent reply other threads:[~2025-09-04 16:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 14:13 [PATCH v2] coresight: trbe: Return NULL pointer for allocation failures Leo Yan
2025-09-04 14:46 ` James Clark
2025-09-04 16:10 ` Markus Elfring [this message]
2025-09-05 12:26 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8dd23cd-9e95-4e2c-8388-54b6d184bcf2@web.de \
--to=markus.elfring@web.de \
--cc=alexander.shishkin@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=coresight@lists.linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=james.clark@linaro.org \
--cc=leo.yan@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=suzuki.poulose@arm.com \
--cc=tamas.zsoldos@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox