From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77CD436A341 for ; Fri, 19 Jun 2026 09:51:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781862714; cv=none; b=uzqfsj4/koh4gEbiluwDhZiW4Bimk3JJ6v7ve4fhAX44Zj2zy+QNWmqWFBIpzaDNy3lvueHaM1pAT6LR3UMEOD2h/aYwwudjxR+RsbIFaOzYsd37Kr67gS6TRz6Q5tL1OMGWKlEnbXu/dzne1erlV4yPwsT5qFJBRKpGju/up4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781862714; c=relaxed/simple; bh=/kWU03eUjVye6hhg9NUKgjZ45aHcq/mzn3B0UlaFXtg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q7dY6zDuJyDTrFtRuYTNrmPws/QPDwMz4J70VwgRBXKTbAOClxjqsgsEiWSqp0fIBbcSsJdhcMBaCCtbS5NmyClss+eQsXwaOuK887HHANfhFsv3FsHNjkLFzJ4n82ZYU+ZqRUKjQaKrLGzPcceUJmc32EveohI23/P+Hq0xtdw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dTeWe7Q9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ko1pNhJR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dTeWe7Q9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ko1pNhJR" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65J7PKZb3620217 for ; Fri, 19 Jun 2026 09:51:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 2h6bbHMCKo8QBg0xCoQbI1gK6dLPx7ToSsyB1dQ41Lo=; b=dTeWe7Q992PCmQNw hydDFe4n7/Yo6D2UA/JrjX3/IhxUSmsZVVbk5i1ysZYlHqaCPF3EZ9dMKSL4T1MG HJN27oz+qa7jBkUSXofWGEI1FJjmvfcYjn5YM0UjyzKRXZVVCy3aosCS+JRrK4o3 afPUf9NjyWPv5iey0fT+oUBXfqJReZ+SNAj39a81jlfetUwSOkdU0M2kSyQoz9AA BOwMkQ7FjmKgkSdhmlP0KI06EYCtjGyNqEebk85hffhLSPekLwzmm0wMgg7kN1jQ j9B+r3lVZgqukv3PBezzIdvanCwccxLXVqrW3/eCKsTqPjVGi2KwHF3bbyHSqega Co7BwQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4evkvf3am9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 19 Jun 2026 09:51:47 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2bf1845bddfso17007115ad.1 for ; Fri, 19 Jun 2026 02:51:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781862707; x=1782467507; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2h6bbHMCKo8QBg0xCoQbI1gK6dLPx7ToSsyB1dQ41Lo=; b=ko1pNhJRcisz7BTkGVwOMiGhEWfFvCaQvxOn0uLegM6lQzWStCsOVFNtZeYseYSZMr IspjEeYMylq4/Dv850al36//Fu/3Y5xrpFlhr/chn6c1uU2ha6FJG+1r2Cwox4u7iM7i m6ObkQfRUme+z6jCkGykPkUpovX8Gx+qPcpjMCmOafjI8jPRZtzniPr9rBtGnMIoGGHr MQVDc+WygML8nR5bncWuFYCqDaKlnmG+Lbj8EyzJkFWMfZnwwyXVmk1RxN8Qn5m2Bs/n zeBRAGrGNZaOK3vZA2mwiJ+laY6AVWTzLMeAZwoRVvQN9OuGzu6wnRdxzyQchNiB0ZBz O4MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781862707; x=1782467507; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2h6bbHMCKo8QBg0xCoQbI1gK6dLPx7ToSsyB1dQ41Lo=; b=CKa5AJ8mpdbdf0NSPx4e23pvMW0yOVtOemt6udR83c8BfJcZXzAfePFc2f8KXOa+V8 FLGuXNx3oKxGWgGJyuc8ceR9cVnDWf5h187lIHMadcMcLLgP1Gf0BnbQxvAgaoWF9OVO i9CgL9yAiGteqm9EsD1RWJBD19L4JMnQy8LaXNSqAerVqRSSkiTOsMvNnXbln6jw8qlA YCvf53jWdLNX8gna56lZQow3VDbQ3Muc0/C5QxnK3tg8FvOarYQykKLkqSfrV9L1olL9 blr3dw/9BmeRbVu4XYDQBclrzZ7X7nO1XhrQqY1Dp1YJyqeq8jmI3/JMj4xWO8SpO2QS EmMA== X-Forwarded-Encrypted: i=1; AFNElJ8BRQzS20WxArGeU3aEAkvkJ7rN0jQ92C6HKqr+1mpGCZmlPGqSSYdK0DRf/nk4mVVYNgPNuArL6Hmzccc=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh1353HOfwz4xrAU7nZX0mkZ4sn+DvJudRn0ifP2aHcQsfwpnh T7+5xp695FVyLYjP0BG1P3g0iwT/+vfxVnipFOixagCmOglX69aeEOWzqW9Y3BQDZMg/ntlm3BK kNrwty1IssoFvxFEkPZmp57BuxGegIFSby2IICo8iX4lz0gFukarfGCEDK/sJ5kXkg3g= X-Gm-Gg: AfdE7cl2vIOk9xjhkAAoP+yOFZQ/BCfRTCkrZPgj5iUpKTLxjWv2KBL8HE5rTDz0Tk6 qD+hFcKoOJaTT9ih2xY6xilbSxRguzmBO3wGmW5lzDfJ4Rj1NrbsrnOfW0dSiat4j2O+HtDBatW lJzvqX0JN+7EVVnB/x+v88Pu6i0k5IAm9dyrQvbkpSCV2lcjOTchSm2caYpQfIoJdq3mcbcBFK0 98fNLsr+36eJxJCAIHyVURlA+wk8h+NyHZMYWXGzG8EUwHC2YQbTv3ct4VXlmkMJ9nKr6NXi32B 4n64/NZzc09o+72DrsdjyO4O9nSyRes5IsWYcZRBr3oOx7YwARxR7w7/U9dP7Q75RVv4FZLmwSs lPKrBR416f9xynTiccSzm72mldfbuhTErwHQvWA== X-Received: by 2002:a17:902:ec82:b0:2c0:cf44:3b3b with SMTP id d9443c01a7336-2c725d7c843mr21063515ad.24.1781862706870; Fri, 19 Jun 2026 02:51:46 -0700 (PDT) X-Received: by 2002:a17:902:ec82:b0:2c0:cf44:3b3b with SMTP id d9443c01a7336-2c725d7c843mr21063035ad.24.1781862706405; Fri, 19 Jun 2026 02:51:46 -0700 (PDT) Received: from [10.219.56.41] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c720c23b8bsm17913045ad.80.2026.06.19.02.51.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Jun 2026 02:51:45 -0700 (PDT) Message-ID: Date: Fri, 19 Jun 2026 15:21:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU To: Konrad Dybcio , Dmitry Baryshkov Cc: Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260526-smmu_interconnect_addition-v2-0-2a6d8ca30d63@oss.qualcomm.com> <20260526-smmu_interconnect_addition-v2-3-2a6d8ca30d63@oss.qualcomm.com> <26d51cbb-2d87-4564-b3c6-cc61ab900e19@oss.qualcomm.com> <3384ecdf-599f-4862-a3c4-9f54b4ddfe63@oss.qualcomm.com> Content-Language: en-US From: Bibek Kumar Patro In-Reply-To: <3384ecdf-599f-4862-a3c4-9f54b4ddfe63@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE5MDA5MSBTYWx0ZWRfX2U30MMFHWX+k PAlgFQs8p2PEt3rYm6UCWUHY4Emq+TEoD1WN17GgMe8mgyi9h/YCswx0N+iUJ81fuLIKYED8gGH 7gxksgtFZUpAmSURPe7878pD9QfoM/I= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE5MDA5MSBTYWx0ZWRfX2AdGJTyDpmc7 PG7Kl7/7LIhh+av3bvwYe8dKpJS/3b6MpWu5qqQTWZHgPqVFcVwgjstu+e1+cg64nVhRZK5Rrn4 tkoSresePFUgu1xqfGvmx6RqT8Elc+13jy6QKnK0Myelt7d/TgwCPfFNN94+MHdL22kg0/jDvU8 Y4+zKxh8EhvLCKuI/Pmw1uSQYQswp1RCsoeeJ54/qek2+zZVtCVadK+6idhpJ/rZ2tjkhVB0T9H mKpun1FtUkb75Cx2qKRw8RXtFrcjFuSSGV91iHh2+m2Yo3ef//hABHoj2L+4nQ29gZXaK61fdrU LIX5KO8Yk47/xSe+B9UoEt7e7NGfUm/lBF4ZZlcUj/5YryTUTjXfbpTLUI0KZT86XIelrhynwnN TmMuR9U7KgCXuWBLN6li9haUA7vfDVEO0sv7SX+crw6UeDo1TVBOnUQ0C7Jo5ijesJAVS9dI2+5 5Li0UQQIVOTEfkqZ/3g== X-Authority-Analysis: v=2.4 cv=H/3rBeYi c=1 sm=1 tr=0 ts=6a351133 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=u9O3v9hlqvzur-BCVJ8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: v9sxNoDd3laXMzXr47GcsiAy1F7OBeLO X-Proofpoint-GUID: v9sxNoDd3laXMzXr47GcsiAy1F7OBeLO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-19_02,2026-06-18_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 impostorscore=0 spamscore=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606190091 On 6/18/2026 2:56 PM, Konrad Dybcio wrote: > On 6/8/26 4:37 PM, Bibek Kumar Patro wrote: >> >> >> On 6/8/2026 7:27 PM, Dmitry Baryshkov wrote: >>> On Tue, May 26, 2026 at 08:12:04PM +0530, Bibek Kumar Patro wrote: >>>> On Kodiak platforms, the Adreno SMMU requires a bandwidth vote on >>>> the GEM_NOC path (MASTER_GPU_TCU -> SLAVE_EBI1) before its registers >>>> are accessible. Without this vote, the SMMU may become unreachable, >>>> leading to intermittent probe failures and runtime issues. >>>> >>>> Add the required interconnect to ensure reliable register access. >>> >>> Does it only concern the GPU SMMU? What about the APPS SMMU? Should it >>> be voting on other interconnects too? I guess so, because currently I >>> see that TBUs vote for various interconnects. BTW: should apps_smmu also >>> vote on the power domains? >>> >> >> This race mainly occurs in GPU SMMU, where the GDSC can have an > > Mainly or exclusively? > It is exclusively in GPU SMMU as of now. We haven't seen any instance on other SMMU, e.g pcie AMMU, APPS SMMU. Also as per my understanding of the architecture which i mentioned earlier [1], this issue will only arise in GPU SMMU. Thanks & regards, Bibek > Konrad > >> independent vote on the Adreno SMMU. However, the GEM_NOC vote may >> already have been removed by the GPU (or any consumer of adreno_smmu, >> e.g gmu), unless it is explicitly voted by the GPU SMMU (which acts as a >> supplier for the GPU). This mismatch can lead to SHUB timeouts or NoC >> errors. >> >> Mostly this race reported in suspend/resume cycle (when gpu/gmu devices moves to slumber/suspend state before adreno_smmu powers down >> and the later doesn't have explicit interconnect voting). >> >> In the case of APPS SMMU, such a race is not expected for any known >> use case. APPS SMMU is part of a shared infrastructure block, and its >> power is typically kept enabled as long as attached master devices are >> active. Therefore, explicit power-domain voting from APPS SMMU may not >> be required. >> [1] >> Thanks, >> Bibek >> >> >>>> >>>> Signed-off-by: Bibek Kumar Patro >>>> --- >>>>   arch/arm64/boot/dts/qcom/kodiak.dtsi | 2 ++ >>>>   1 file changed, 2 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> index fa540d8c2615dc02d941eb16bc7253204c2750bd..eefa4b836a81374ff437ab4bbcbc3fecc1590ab6 100644 >>>> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi >>>> @@ -3386,6 +3386,8 @@ adreno_smmu: iommu@3da0000 { >>>>                 power-domains = <&gpucc GPU_CC_CX_GDSC>; >>>>               dma-coherent; >>>> +            interconnects = <&gem_noc MASTER_GPU_TCU QCOM_ICC_TAG_ALWAYS >>>> +                     &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>; >>>>           }; >>>>             gfx_0_tbu: tbu@3dd9000 { >>>> >>>> -- >>>> 2.34.1 >>>> >>> >> >>