public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Shengyu Qu <wiagn233@outlook.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
	hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v1] net: sfp: add quirks for ODI DFP-34X-2C2
Date: Mon, 26 Feb 2024 16:06:49 +0100	[thread overview]
Message-ID: <b8fdb5df-57e4-491a-b310-e8e13a89d331@lunn.ch> (raw)
In-Reply-To: <TY3P286MB261155090B2D07593901C0DE985A2@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>

> Well, that seems some kind weird trick implemented in that chip's SDK (maybe
> hardware?). It would automatically detect the speed rate that host uses and
> switch to that rate. The system log of the stick shows that.

Please could you show some examples from the system log.

If this patch is accepted, these details need to be in the commit
message, to explain how this actually works, when it should not
actually work....

       Andrew

  reply	other threads:[~2024-02-26 15:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 13:23 [PATCH v1] net: sfp: add quirks for ODI DFP-34X-2C2 Shengyu Qu
2024-02-26 14:04 ` Russell King (Oracle)
2024-02-26 14:16   ` Shengyu Qu
2024-02-26 14:39     ` Russell King (Oracle)
2024-02-26 14:51       ` Shengyu Qu
2024-02-26 15:06         ` Andrew Lunn [this message]
2024-02-26 15:20           ` Shengyu Qu
2024-02-26 15:50             ` Russell King (Oracle)
2024-02-26 15:42           ` Shengyu Qu
2024-02-26 15:52             ` Andrew Lunn
2024-02-26 15:42         ` Russell King (Oracle)
2024-02-26 15:51           ` Shengyu Qu
2024-02-28 10:42           ` Shengyu Qu
2024-02-28 11:15             ` Russell King (Oracle)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b8fdb5df-57e4-491a-b310-e8e13a89d331@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=wiagn233@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox