linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Konrad Leszczynski <konrad.leszczynski@intel.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	davem@davemloft.net, andrew+netdev@lunn.ch, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, cezary.rojewski@intel.com,
	sebastian.basierski@intel.com
Subject: Re: [PATCH net-next 0/7] net: stmmac: fixes and new features
Date: Thu, 28 Aug 2025 16:40:22 +0200	[thread overview]
Message-ID: <b91f62a3-e34e-4881-bf7f-4e5cd299e77c@lunn.ch> (raw)
In-Reply-To: <240b5f17-30cd-42f4-9dcd-4d5b60aa7bec@intel.com>

On Thu, Aug 28, 2025 at 02:51:51PM +0200, Konrad Leszczynski wrote:
> 
> On 28-Aug-25 14:25, Andrew Lunn wrote:
> > On Thu, Aug 28, 2025 at 08:47:02AM +0200, Konrad Leszczynski wrote:
> > > On 26-Aug-25 19:29, Vadim Fedorenko wrote:
> > > > On 26/08/2025 12:32, Konrad Leszczynski wrote:
> > > > > This series starts with three fixes addressing KASAN panic on ethtool
> > > > > usage, Enhanced Descriptor printing and flow stop on TC block setup when
> > > > > interface down.
> > > > > Everything that follows adds new features such as ARP Offload support,
> > > > > VLAN protocol detection and TC flower filter support.
> > > > Well, mixing fixes and features in one patchset is not a great idea.
> > > > Fixes patches should have Fixes: tags and go to -net tree while features
> > > > should go to net-next. It's better to split series into 2 and provide
> > > > proper tags for the "fixes" part
> > > Hi Vadim,
> > > 
> > > Thanks for the review. I've specifically placed the fixes first and the
> > > features afterwards to not intertwine the patches. I can split them into two
> > > patchsets if you think that's the best way to go.
> > https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
> > 
> > You probably need to wait a week between the fixes and new features in
> > order that net and net-next are synced.
> > 
> >      Andrew
> > 
> > ---
> > pw-bot: cr
> > 	
> 
> Hi Andrew. Thanks for the heads-up. Fixes are new features are independent
> from each other. Should I still wait a week to send out the patchset
> containing the new features?

What you want to avoid is causing the netdev Maintainers to resolve
merge conflicts when net-next and net are merged. By waiting a week,
you get to resolve such conflicts.

    Andrew

      parent reply	other threads:[~2025-08-28 14:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-26 11:32 [PATCH net-next 0/7] net: stmmac: fixes and new features Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 1/7] net: stmmac: replace memcpy with strscpy in ethtool Konrad Leszczynski
2025-08-27 19:13   ` Simon Horman
2025-08-26 11:32 ` [PATCH net-next 2/7] net: stmmac: correct Tx descriptors debugfs prints Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 3/7] net: stmmac: check if interface is running before TC block setup Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 4/7] net: stmmac: enable ARP Offload on mac_link_up() Konrad Leszczynski
2025-08-26 17:05   ` kernel test robot
2025-08-27 19:28   ` Simon Horman
2025-08-26 11:32 ` [PATCH net-next 5/7] net: stmmac: set TE/RE bits for ARP Offload when interface down Konrad Leszczynski
2025-08-26 11:32 ` [PATCH net-next 6/7] net: stmmac: enhance VLAN protocol detection for GRO Konrad Leszczynski
2025-08-27 19:35   ` Simon Horman
2025-08-26 11:32 ` [PATCH net-next 7/7] net: stmmac: add TC flower filter support for IP EtherType Konrad Leszczynski
2025-08-27 19:37   ` Simon Horman
2025-08-28  9:46     ` Konrad Leszczynski
2025-08-26 17:29 ` [PATCH net-next 0/7] net: stmmac: fixes and new features Vadim Fedorenko
2025-08-28  6:47   ` Konrad Leszczynski
2025-08-28 12:25     ` Andrew Lunn
2025-08-28 12:51       ` Konrad Leszczynski
2025-08-28 13:21         ` Vadim Fedorenko
2025-08-28 14:40         ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b91f62a3-e34e-4881-bf7f-4e5cd299e77c@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andrew+netdev@lunn.ch \
    --cc=cezary.rojewski@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=konrad.leszczynski@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sebastian.basierski@intel.com \
    --cc=vadim.fedorenko@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).