From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D646EB64DB for ; Tue, 20 Jun 2023 10:09:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231383AbjFTKJp (ORCPT ); Tue, 20 Jun 2023 06:09:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229830AbjFTKJm (ORCPT ); Tue, 20 Jun 2023 06:09:42 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 574C9A2; Tue, 20 Jun 2023 03:09:38 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 3EBEE8175; Tue, 20 Jun 2023 18:09:36 +0800 (CST) Received: from EXMBX073.cuchost.com (172.16.6.83) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 20 Jun 2023 18:09:36 +0800 Received: from [192.168.60.140] (180.164.60.184) by EXMBX073.cuchost.com (172.16.6.83) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 20 Jun 2023 18:09:35 +0800 Message-ID: Date: Tue, 20 Jun 2023 18:09:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 0/5] Add support for external dphy Content-Language: en-US To: Mauro Carvalho Chehab , Maxime Ripard , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Laurent Pinchart CC: , , , References: <20230523085626.3295-1-jack.zhu@starfivetech.com> From: Jack Zhu In-Reply-To: <20230523085626.3295-1-jack.zhu@starfivetech.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [180.164.60.184] X-ClientProxiedBy: EXCAS062.cuchost.com (172.16.6.22) To EXMBX073.cuchost.com (172.16.6.83) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/5/23 16:56, Jack Zhu wrote: > This series adds support for external D-PHY and JH7110 SoC which has a Cadence > MIPI-CSI2 RX controller. The driver is tested on VisionFive V2 board. > Hi everyone, For this new version of patch, could you please help to review and give your comments? Thanks a lot! > PLEASE NOTE: this patch series was spun off from the v4 of another series that > included CSI and ISP driver. You can check the comments for earlier version in > the link below. I'm sorry that the first version link has been lost. > > v4 link: https://lore.kernel.org/all/20230413035541.62129-1-jack.zhu@starfivetech.com/ > v3 link: https://lore.kernel.org/all/20230331121826.96973-1-jack.zhu@starfivetech.com/ > v2 link: https://lore.kernel.org/all/20230310120553.60586-1-jack.zhu@starfivetech.com/ > > Current review status: > - cdns,csi2rx.yaml: > Reviewed by: Krzysztof Kozlowski > Reviewed by: Laurent Pinchart > - cdns-csi2rx.c > Reviewed by: Laurent Pinchart > - MAINTAINERS > Reviewed by: Krzysztof Kozlowski > Reviewed by: Laurent Pinchart > > Thanks to everyone who reviewed my work ! > > Changes in v2: > - Matched reset names in bindings. > > v1 link: https://lore.kernel.org/all/20230512102637.50917-1-jack.zhu@starfivetech.com/ > > Jack Zhu (5): > media: dt-bindings: cadence-csi2rx: Convert to DT schema > media: dt-bindings: cadence-csi2rx: Add resets property > media: cadence: Add operation on reset > media: cadence: Add support for external dphy > media: cadence: Add support for JH7110 SoC > > .../devicetree/bindings/media/cdns,csi2rx.txt | 100 --------- > .../bindings/media/cdns,csi2rx.yaml | 201 ++++++++++++++++++ > MAINTAINERS | 1 + > drivers/media/platform/cadence/cdns-csi2rx.c | 107 ++++++++-- > 4 files changed, 294 insertions(+), 115 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.txt > create mode 100644 Documentation/devicetree/bindings/media/cdns,csi2rx.yaml >