From: Hayes Wang <hayeswang@realtek.com>
To: Sven van Ashbrook <svenva@chromium.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Alex Levin <levinale@google.com>,
Chithra Annegowda <chithraa@google.com>,
Frank Gorgenyi <frankgor@google.com>,
Aaron Ma <aaron.ma@canonical.com>,
David Ober <dober6023@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Hao Chen <chenhao288@hisilicon.com>,
Jakub Kicinski <kuba@kernel.org>,
Jean-Francois Le Fillatre <jflf_kernel@gmx.com>,
Paolo Abeni <pabeni@redhat.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next v1] r8152: allow userland to disable multicast
Date: Wed, 31 Aug 2022 03:14:42 +0000 [thread overview]
Message-ID: <b94fb55a06cc4ea5aeb32e919e9607a1@realtek.com> (raw)
In-Reply-To: <20220830045923.net-next.v1.1.I4fee0ac057083d4f848caf0fa3a9fd466fc374a0@changeid>
Sven van Ashbrook <svenva@chromium.org>
> Sent: Tuesday, August 30, 2022 1:00 PM
[...]
> The rtl8152 driver does not disable multicasting when userspace asks
> it to. For example:
> $ ifconfig eth0 -multicast -allmulti
> $ tcpdump -p -i eth0 # will still capture multicast frames
>
> Fix by clearing the device multicast filter table when multicast and
> allmulti are both unset.
>
> Tested as follows:
> - Set multicast on eth0 network interface
> - verify that multicast packets are coming in:
> $ tcpdump -p -i eth0
> - Clear multicast and allmulti on eth0 network interface
> - verify that no more multicast packets are coming in:
> $ tcpdump -p -i eth0
>
> Signed-off-by: Sven van Ashbrook <svenva@chromium.org>
Acked-by: Hayes Wang <hayeswang@realtek.com>
Best Regards,
Hayes
next prev parent reply other threads:[~2022-08-31 3:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 4:59 [PATCH net-next v1] r8152: allow userland to disable multicast Sven van Ashbrook
2022-08-31 3:14 ` Hayes Wang [this message]
2022-08-31 22:00 ` patchwork-bot+netdevbpf
2022-08-31 22:32 ` Sven van Ashbrook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b94fb55a06cc4ea5aeb32e919e9607a1@realtek.com \
--to=hayeswang@realtek.com \
--cc=aaron.ma@canonical.com \
--cc=chenhao288@hisilicon.com \
--cc=chithraa@google.com \
--cc=davem@davemloft.net \
--cc=dober6023@gmail.com \
--cc=edumazet@google.com \
--cc=frankgor@google.com \
--cc=jflf_kernel@gmx.com \
--cc=kuba@kernel.org \
--cc=levinale@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=svenva@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox