From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: ACJfBouWDzWFHLukxLTc1xY97qeBTRrxUuwR9kgWsOnav3sqlJn/okl7cVph7niN3QMjoPhhCf8+ ARC-Seal: i=1; a=rsa-sha256; t=1516378949; cv=none; d=google.com; s=arc-20160816; b=w3Ox82821ZrscJBl9ihs14H25HptPODnI+/fmXX9EeEj9OuNI6XgjDPevDKgZTLmHc be6iQSvYMXeDiPzBgZv15v99m2TOYSch0GzC+JVCsqyFodBgJL1QD2WbGD16GP18MLgs P0eBjiZjFXjkAYIb7YYYwW5rbaGiARAwdb+ympTlOrTTmbjOe5+KBSSonufykL7x1B0g x68yU1l/Yya9HNHgqq2mUv+Fn4ZAEXRQfLFoyXmxALkqOvU6dH2hCttgqr3vZikpK7hf WKTotNRQKUWQbmsQhs9k+6Gteid6WPSb2olMeMTCrKDWqyJLxmx+Z1uhnt6S3PrAxGx9 BBiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:message-id:references:in-reply-to:subject:cc:to:from :date:content-transfer-encoding:mime-version:dkim-signature :dkim-signature:arc-authentication-results; bh=DxXfBYYOZAkQmxUMXrgZE5jQlm49lbI0YtnxHu+oImQ=; b=P4fQ4i4CrqJbnZKHA2NrrEQGWNGnq31Kbor2XWiwcuyQ6kQDzjxedUWm7X7OV+BPfv 4KP3nT3yPc7yvhPGyi/XXxZrRa0VgM09ki8NtNWsHwAWkgJD/jPglw/Ak6mPlT8u3GPI /bisYTwCTNaukQgXTGgJlcbOgQ85hoKWn8e4S7Xelgs4dqHWj0SWvHSNdNcxKjQ1WTN3 7FnQ3Sj75P8FcYAJkvcENPzwDn+c03UHI60FV/td6Wxbn4vfbB7ILFimxHSbD1JV3udu n7pNLSM3YWX0j8CR7Vmz1BUfzoUeHAHXecTVlLYyxed/fR1VSpjjpuMLdSASrXBp1tC1 7X0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=FWlSCHTp; dkim=pass header.i=@codeaurora.org header.s=default header.b=R5n22IvW; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=FWlSCHTp; dkim=pass header.i=@codeaurora.org header.s=default header.b=R5n22IvW; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 19 Jan 2018 21:52:28 +0530 From: poza@codeaurora.org To: Sinan Kaya Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Timur Tabi Subject: Re: [PATCH v6 7/7] PCI: Unify wait for link active into generic pci In-Reply-To: <10da80a3-e058-1a21-7af2-405c99b7991e@codeaurora.org> References: <1516360204-1586-1-git-send-email-poza@codeaurora.org> <1516360204-1586-8-git-send-email-poza@codeaurora.org> <10da80a3-e058-1a21-7af2-405c99b7991e@codeaurora.org> Message-ID: User-Agent: Roundcube Webmail/1.2.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590018961580197637?= X-GMAIL-MSGID: =?utf-8?q?1590038573742536675?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 2018-01-19 19:47, Sinan Kaya wrote: > On 1/19/2018 6:10 AM, Oza Pawandeep wrote: >> +++ b/drivers/pci/pcie/pcie-dpc.c >> @@ -150,37 +150,9 @@ static void dpc_wait_link_inactive(struct dpc_dev >> *dpc) >> struct pci_dev *pdev = dpc->dev->port; >> struct device *dev = &dpc->dev->device; >> u16 lnk_status; >> + bool active = false; >> >> - pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status); >> - while (lnk_status & PCI_EXP_LNKSTA_DLLLA && >> - !time_after(jiffies, timeout)) { >> - msleep(10); >> - pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status); >> - } >> - if (lnk_status & PCI_EXP_LNKSTA_DLLLA) >> - dev_warn(dev, "Link state not disabled for DPC event\n"); >> -} > > I think you should reorder 6 and 7 to eliminate this. Sure will reorder them Regards, Oza.