public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Judith Mendez <jm@ti.com>, Nishanth Menon <nm@ti.com>,
	Vignesh Raghavendra <vigneshr@ti.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Andrew Davis <afd@ti.com>,
	Bryan Brattlof <bb@ti.com>
Subject: Re: [PATCH 2/2] arm64: dts: ti: Add k3-am62l3-beaglebadge
Date: Sun, 3 May 2026 13:25:52 +0200	[thread overview]
Message-ID: <b96543f2-8907-4128-8f77-f670c22bbf7d@kernel.org> (raw)
In-Reply-To: <20260501233148.4180391-3-jm@ti.com>

On 02/05/2026 01:31, Judith Mendez wrote:
> BeagleBoard.org BeagleBadge is a compact, affordable open source
> hardware single board computer based on the Texas Instruments AM62L3
> SoC designed for IoT and embedded applications with low power consumption.
> Expansion is provided over open standards based headers including
> QWIIC and GPIO interfaces.
> 
> https://beagleboard.org/
> https://github.com/beagleboard/BeagleBadge
> 
> Co-developed-by: Andrew Davis <afd@ti.com>

Incomplete DCO. Please read carefully submitting patches to understand
what you should do here.

> Signed-off-by: Judith Mendez <jm@ti.com>

...

> +&spi3 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&spi3_pins_default>;
> +	status = "okay";
> +
> +	sx1262_lora: lora@0 {

Heh? Lora?

> +		compatible = "rohm,dh2228fv";

Nope, you don't have this device. Stop faking stuff. dh2228fv DOES NOT
EXIST! How could you put to hardware something which does not even exist?

> +		reg = <0>;
> +		spi-max-frequency = <10000000>;
> +	};
> +};


Best regards,
Krzysztof

  reply	other threads:[~2026-05-03 11:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01 23:31 [PATCH 0/2] arm64: dts/bindings: Add support for BeagleBadge Judith Mendez
2026-05-01 23:31 ` [PATCH 1/2] dt-bindings: arm: ti: Add am62l3-badge Judith Mendez
2026-05-01 23:31 ` [PATCH 2/2] arm64: dts: ti: Add k3-am62l3-beaglebadge Judith Mendez
2026-05-03 11:25   ` Krzysztof Kozlowski [this message]
2026-05-04 15:18   ` Andrew Davis
2026-05-04 16:19   ` Bryan Brattlof

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b96543f2-8907-4128-8f77-f670c22bbf7d@kernel.org \
    --to=krzk@kernel.org \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jm@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox