Re: [PATCH v3 32/54] selftests/mm: gup_longterm: add setup of HugeTLB pages

Sarthak Sharma
2026-05-06T12:15:43Z

On 4/29/26 2:12 AM, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> gup_longterm tests skips HugeTLB tests if there are no free huge pages
> prepared by a wrapper script.
>
> Add setup of HugeTLB pages to the test and make sure that the original
> settings are restored on the test exit.
>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>

I have run the test before and after applying the patch. Before the
patch, many tests were skipped with the message "need more free huge
pages". After the patch, these tests passed successfully.

Tested-by: Sarthak Sharma <sarthak.sharma@arm.com>

> ---
> tools/testing/selftests/mm/gup_longterm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/mm/gup_longterm.c b/tools/testing/selftests/mm/gup_longterm.c
> index ab4eaf4feb7c..6e1de12bf28c 100644
> --- a/tools/testing/selftests/mm/gup_longterm.c
> +++ b/tools/testing/selftests/mm/gup_longterm.c
> @@ -510,7 +510,7 @@ int main(int argc, char **argv)
> int i;
>
> pagesize = getpagesize();
> - nr_hugetlbsizes = detect_hugetlb_page_sizes(hugetlbsizes,
> + nr_hugetlbsizes = hugetlb_setup(2, hugetlbsizes,
> ARRAY_SIZE(hugetlbsizes));
>
> ksft_print_header();