From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 015FD3B4E95; Fri, 5 Jun 2026 09:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780652673; cv=none; b=sB6j34AbMARl8Vd1TQVMLBdEP1KZD9wORexieBmQ/zRHU9RVzOcKlOTWCoKklEU6ll485Hepep6wiA3uKA/L7nGI99TJCGvtROkvAC03jjaQeWYX+OBQxljUHr0meJDH1wlJh5hZE5CR5XBy9yEmUh3jUVewy7qR5HU67HO3QJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780652673; c=relaxed/simple; bh=cGvDObAP4P1TiHE39uvL+EQac6KNJ3MwKLuJY4wnrvs=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=fok8ECbGe1HVCbnGbx7qZ+ngZisyhv/MUDJDAIxOVY6W0upa4gZRSrqwO7SptIvbILoLXyipT1563WxNUofrKrscgQa/eFDidJsDRLd8qynU2z++Hm1L1P8E8T98u6CInC4yh0rvKuXCLxsuXudECVcd6OXOm1muFp4oXH7U/EI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn; spf=pass smtp.mailfrom=realsil.com.cn; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b=ZN9FrNXz; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realsil.com.cn Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=realsil.com.cn header.i=@realsil.com.cn header.b="ZN9FrNXz" X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 6559hsl671289396, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realsil.com.cn; s=dkim; t=1780652634; bh=AMwMhcr15Ang8zfVdQkUS0kraiuhJd0fnSuvIEPN3iY=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:Content-Transfer-Encoding:MIME-Version; b=ZN9FrNXzWdUyrrTotlM4Gw02gKE1soSbnIrtN2fVyTqxA7+mzO1rnca4W3zJ7xoL+ oe8l1Wgv3YSJDzso9IiDZco/qKcrUI2mJR9LaV9UeYjURexNBq56W2fXYHzXTfMmeX Nim0LgWpfNiEdTJ6vSJtn2k+C1rV3q3Uxqu3RZWDRfZGYcv8wCtn1kdWY6DP60reA8 X5sqR76VxB2d3y51yt6DVMvLVMFU+/6u2aLoOFfauk22L6BBset+p0zZifI75/n3Yr tjQkUOKFFOmXkOCex9uoHEqL3UK5pO95GB7t4tdGLTaIamc7yq2So824M5SkKqM9j0 g3RW0Pb6EFcYg== Received: from RS-EX-MBS4.realsil.com.cn ([172.29.17.104]) by rtits2.realtek.com.tw (8.15.2/3.28/5.94) with ESMTPS id 6559hsl671289396 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 5 Jun 2026 17:43:54 +0800 Received: from RS-EX-MBS3.realsil.com.cn (172.29.17.103) by RS-EX-MBS4.realsil.com.cn (172.29.17.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Fri, 5 Jun 2026 17:43:54 +0800 Received: from RS-EX-MBS3.realsil.com.cn ([172.29.17.103]) by RS-EX-MBS3.realsil.com.cn ([172.29.17.103]) with mapi id 15.02.2562.017; Fri, 5 Jun 2026 17:43:54 +0800 From: Javen To: Andrew Lunn CC: Maxime Chevallier , "hkallweit1@gmail.com" , "nic_swsd@realtek.com" , "andrew+netdev@lunn.ch" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "horms@kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH net-next v1 1/5] net: phy: realtek: add support for dummy phy Thread-Topic: [PATCH net-next v1 1/5] net: phy: realtek: add support for dummy phy Thread-Index: AQHc8yZ/Mp8SA5nBjkWeW0kSVYYOAbYr622AgACJVcD//4tpAIAAiC6A//+HfoCAAIdu8P//skuAAG3JDHA= Date: Fri, 5 Jun 2026 09:43:54 +0000 Message-ID: References: <20260603065916.334-1-javen_xu@realsil.com.cn> <20260603065916.334-2-javen_xu@realsil.com.cn> <7496c873-fee7-4584-ad70-4315d7b94f8f@bootlin.com> <0bc2ae0e-316c-447e-9098-f18f4b491328@bootlin.com> <7c35fa5bb5f24afdb42e2d45a4e559c3@realsil.com.cn> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, >> You are exactly right. The PHY doesn't actually exist; what we have is >> an internal PCS. > >... > >> I actually tried to migrate it to >> phylink before. However, the current driver codebase is deeply coupled >> with tp->phydev in many places. Decoupling it may introduce bugs for >> numerous existing devices. Therefore, I want to try to expose the >> internal PCS as a dummy PHY device. > >Architecturally, you are going down a dead end. You really should be using >phylink. > >I don't see anything too scary with tp->phydev in the driver. Are there pa= rts >you think are going to be a problem with phylink? > > Andrew Thanks for your suggestion. Since I am not very familiar with phylink, so I may have been too conserv= ative about the migration. I have prepared a version using phylink and will= submit it for review. Any comments or suggestions would be very helpful. Thanks, BRs, Javen