Re: [PATCH v2 0/2] platform/x86: msi-wmi: Fix unknown wmi event messages on MSI Claw models

[Armin Wolf <W_Armin@gmx.de>]

Am 13.06.26 um 04:16 schrieb Derek J. Clark:

> MSI Claw devices produce WMI events through the MSI WMI hotkeys GUID for
> some of their buttons. When pressed, these cause spam in the kernel. The
> Claws use a GUID already supported by msi-wmi, but use an
> ACPI_TYPE_BUFFER instead of an ACPI_TYPE_INTEGER.
>
> Patch 1 reformats msi_wmi_notify() to reduce nesting by using early
> returns and a switch case in preparation for handling this new data
> type.
>
> Patch 2 adds known MSI Claw event keycodes to the keymap and support for
> ACPI_TYPE_BUFFER.

For the whole series:

Reviewed-by: Armin Wolf <W_Armin@gmx.de>

>
> Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com>
> ---
> v2:
>    - Add comments explaining buffer fields & length.
>    - Test that we have at lease u8[2] before assignment of key ID
> v1: https://lore.kernel.org/platform-driver-x86/20260611223920.1679438-1-derekjohn.clark@gmail.com/
> Derek J. Clark (2):
>    platform/x86: msi-wmi: Reformat msi_wmi_notify()
>    platform/x86: msi-wmi: Add MSI Claw M-Center keys
>
>   drivers/platform/x86/msi-wmi.c | 97 +++++++++++++++++++++++-----------
>   1 file changed, 65 insertions(+), 32 deletions(-)
>