From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751904AbdJPCqY (ORCPT <rfc822;w@1wt.eu>);
        Sun, 15 Oct 2017 22:46:24 -0400
Received: from mga06.intel.com ([134.134.136.31]:30219 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751825AbdJPCqX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 15 Oct 2017 22:46:23 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,385,1503385200"; 
   d="scan'208";a="163000832"
Subject: Re: [RFC PATCH v2 1/8] cpuidle: menu: extract prediction
 functionality
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Aubrey Li <aubrey.li@intel.com>
Cc: tglx@linutronix.de, peterz@infradead.org, len.brown@intel.com,
        ak@linux.intel.com, tim.c.chen@linux.intel.com,
        linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1506756034-6340-1-git-send-email-aubrey.li@intel.com>
 <1506756034-6340-2-git-send-email-aubrey.li@intel.com>
 <1629755.KbDSmDPDTX@aspire.rjw.lan>
From: "Li, Aubrey" <aubrey.li@linux.intel.com>
Message-ID: <b9dc3eea-cd55-e2a5-71b7-f3c0a548e92b@linux.intel.com>
Date: Mon, 16 Oct 2017 10:46:20 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <1629755.KbDSmDPDTX@aspire.rjw.lan>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017/10/14 8:26, Rafael J. Wysocki wrote:
> On Saturday, September 30, 2017 9:20:27 AM CEST Aubrey Li wrote:
>> There are several factors in the menu governor to predict the next
>> idle interval:
>> - the next timer
>> - the recent idle interval history
>> - the corrected idle interval pattern
>> These factors are common enough to be extracted to be one function.
>>
>> Signed-off-by: Aubrey Li <aubrey.li@linux.intel.com>
> 
> This patch alone would break things AFAICS, because it removes code from
> menu_select() without a replacement (and menu_predict() is never called
> just yet).
> 
> Please always do your best to ensure that things will work after *every*
> patch in a series.

okay, I'll correct this in the next version.

Thanks,
-Aubrey