From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jeff Chua <jeff.chua.linux@gmail.com>, Takashi Iwai <tiwai@suse.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>, Len Brown <lenb@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: Commit 500f7147cf5bafd139056d521536b10c2bc2e154 breaks _resume_
Date: Tue, 08 Feb 2011 13:36:06 +0000 [thread overview]
Message-ID: <b9dded$hsnlfd@orsmga002.jf.intel.com> (raw)
In-Reply-To: <AANLkTim2czZfsbGaG=K-=dV5hENgUOUhjBpWoa+mTjyb@mail.gmail.com>
On Mon, 7 Feb 2011 22:11:29 +0800, Jeff Chua <jeff.chua.linux@gmail.com> wrote:
> Same issue encountered even after a fresh build.
I've been testing on the same hardware (x201s, 64bit, with and without
external DP) and I've not encountered the same issue. Every time I look
at the code, by not setting crtc->active we may incorrectly skip disabling
an active output after resume. If the output is inactive, then disabling it
*should* be a no-op, and thus safe. So I am still at a loss to understand
what fails here and so whether we have a bigger problem on our hands.
Please can you add drm.debug=0xe to your boot parameters (or echo 0xe >
/sys/module/drm/parameters/debug might just be enough) and attach the
dmesg whilst resuming. Also attaching the failing Xorg.0.log would be
useful to rule out any other issues.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-02-08 13:36 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 1:50 Commit 500f7147cf5bafd139056d521536b10c2bc2e154 breaks _resume_ Jeff Chua
2011-02-06 8:19 ` Marc Koschewski
2011-02-06 11:02 ` Takashi Iwai
2011-02-06 11:06 ` Dave Airlie
2011-02-06 12:21 ` Marc Koschewski
2011-02-06 13:04 ` Rafael J. Wysocki
2011-02-06 13:44 ` Marc Koschewski
2011-02-06 13:55 ` Rafael J. Wysocki
2011-02-06 11:00 ` Takashi Iwai
2011-02-06 12:24 ` Marc Koschewski
2011-02-06 13:19 ` Takashi Iwai
2011-02-06 14:01 ` Jeff Chua
2011-02-06 14:47 ` Chris Wilson
2011-02-06 14:51 ` Jeff Chua
2011-02-06 14:49 ` Jeff Chua
2011-02-06 15:27 ` Chris Wilson
2011-02-07 4:48 ` Jeff Chua
2011-02-07 5:02 ` Jeff Chua
2011-02-07 8:25 ` Takashi Iwai
2011-02-07 8:36 ` Jeff Chua
2011-02-07 8:45 ` Jeff Chua
2011-02-07 8:54 ` Takashi Iwai
2011-02-07 8:52 ` Takashi Iwai
2011-02-07 10:15 ` Takashi Iwai
2011-02-07 13:38 ` Jeff Chua
2011-02-07 14:11 ` Jeff Chua
2011-02-07 21:20 ` Rafael J. Wysocki
2011-02-08 1:40 ` Jeff Chua
2011-02-08 13:36 ` Chris Wilson [this message]
2011-02-09 0:55 ` Jeff Chua
2011-02-09 1:05 ` Jeff Chua
2011-02-09 2:56 ` Indan Zupancic
2011-02-09 5:45 ` Jeff Chua
2011-02-09 9:42 ` Indan Zupancic
2011-02-09 9:32 ` Chris Wilson
2011-02-09 10:20 ` Indan Zupancic
2011-02-07 10:02 ` Marc Koschewski
2011-02-07 10:06 ` Takashi Iwai
2011-02-07 10:09 ` Marc Koschewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b9dded$hsnlfd@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=jeff.chua.linux@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox