From: "Rakib Mullick" <rakib.mullick@gmail.com>
To: "Pavel Machek" <pavel@suse.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
"Linux-kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Ingo Molnar" <mingo@elte.hu>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] kernel/freezer.c : Removing extra checking.
Date: Fri, 12 Dec 2008 21:01:20 +0600 [thread overview]
Message-ID: <b9df5fa10812120701q72bdcc3cue59e22bb2c295ee0@mail.gmail.com> (raw)
In-Reply-To: <20081211123152.GA1842@ucw.cz>
On 12/11/08, Pavel Machek <pavel@suse.cz> wrote:
>
> Plus this looks like infinite loop after your change. Have you tested
> it?
No. I haven't tested it. But very soon I'll try to test it.
Well, you said pending signal. What will happen when a pending signal
will send. In current code check is made to make sure that the task is
frozen or not. I mean , when a signal is send ( from theoritical POV,
which could be any ) this code doesn't make sure what will happen to
that perticular process.
It is already a infinite loop, the check is made to make sure that
whether the task will be scheduled or not.
Thanks,
Rakib
>
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>
prev parent reply other threads:[~2008-12-12 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-06 8:20 [PATCH] kernel/freezer.c : Removing extra checking Rakib Mullick
2008-12-06 13:41 ` Rafael J. Wysocki
2008-12-06 15:04 ` Rakib Mullick
2008-12-06 16:52 ` Rafael J. Wysocki
2008-12-11 12:31 ` Pavel Machek
2008-12-12 15:01 ` Rakib Mullick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9df5fa10812120701q72bdcc3cue59e22bb2c295ee0@mail.gmail.com \
--to=rakib.mullick@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox