From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Henry Shi <henryshi2018@gmail.com>
Cc: hbshi69@hotmail.com, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org,
hpa@zytor.com, "Hans de Goede" <hdegoede@redhat.com>,
markgross@kernel.org, jdelvare@suse.com, linux@roeck-us.net,
LKML <linux-kernel@vger.kernel.org>,
platform-driver-x86@vger.kernel.org, linux-hwmon@vger.kernel.org,
hb_shi2003@yahoo.com, henrys@silicom-usa.com,
wenw@silicom-usa.com, "Barnabás Pőcze" <pobrn@protonmail.com>
Subject: Re: [PATCH v15] platform/x86: Add Silicom Platform Driver
Date: Tue, 28 Nov 2023 14:54:48 +0200 (EET) [thread overview]
Message-ID: <b9e2321c-7dfb-d2d5-6cb-e3fa1ded1422@linux.intel.com> (raw)
In-Reply-To: <20231124200334.5318-1-henryshi2018@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 729 bytes --]
On Fri, 24 Nov 2023, Henry Shi wrote:
> platform/x86: Add Silicom Platform Driver
>
> Add Silicom platform (silicom-platform) Linux driver for Swisscom
> Business Box (Swisscom BB) as well as Cordoba family products.
>
> This platform driver provides support for various functions via
> the Linux LED framework, GPIO framework, Hardware Monitoring (HWMON)
> and device attributes.
>
> Signed-off-by: Henry Shi <henryshi2018@gmail.com>
As far as I'm concerned, this seems to be okay shape now:
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
It would be good for somebody to check if the devicename part of the led
.name is correct (as I cannot even myself figure out what exactly is
expected there).
--
i.
next prev parent reply other threads:[~2023-11-28 12:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 20:03 [PATCH v15] platform/x86: Add Silicom Platform Driver Henry Shi
2023-11-28 12:54 ` Ilpo Järvinen [this message]
2023-12-04 12:49 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9e2321c-7dfb-d2d5-6cb-e3fa1ded1422@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hb_shi2003@yahoo.com \
--cc=hbshi69@hotmail.com \
--cc=hdegoede@redhat.com \
--cc=henrys@silicom-usa.com \
--cc=henryshi2018@gmail.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markgross@kernel.org \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
--cc=tglx@linutronix.de \
--cc=wenw@silicom-usa.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox