From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 299B32FAC14 for ; Fri, 14 Nov 2025 20:51:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763153511; cv=none; b=NZLWLdG10132MFSVGD63WG0iYwh8g6CO026RHahUw1mMl6Q9YxZmv6b+FOzVoZsgxSDXWrO5ris4oM2KTIOKNF9d5XFiOyuonYpMhZEV9DfhYqJRkw0LfKVTgl8jiFqE04DsWIzNpgSI6xyEi1dTHqAOqe/eEP8Y7F1dZyXSP8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763153511; c=relaxed/simple; bh=QHanXXg+OyeerrpmISPQdni+CiKbUE36s486c89hzlU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SpBqTmjcUWoNt5MnermqxcgFLP0uriWjjj70VHr2DDgmV5ZI9ZxxKS/r0e+HsiRPBQ1y2t9V+FbACxXEeYbXA06Xh2nuDUWhBf83xYjdbO6LJ+0kXgqexLrMQCkAvVZt9jjyG3SLTpob+XDdCscq7DjUGgFVhCRVUWwg+vNif3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=ixD2vmHs; arc=none smtp.client-ip=209.85.166.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="ixD2vmHs" Received: by mail-io1-f44.google.com with SMTP id ca18e2360f4ac-948cda204a7so174787939f.3 for ; Fri, 14 Nov 2025 12:51:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1763153508; x=1763758308; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=r5fX1MysWhFmcB+WwiW0z8iIPBJH7K9A9qIpnyNOJTI=; b=ixD2vmHsXg35O4bIBmbhneRW/CKwiInwhj3TAw85SNWfYBCLS+GSJKE4FnIEqxaQZw ztLuSEqeJB7KV2RQxROAiGVebCfkYBUYecYBhczavZekmWsmhJVvx5cVJju5jwMhjNs4 lTCCt23pt967NU27UpABTrtyVqO7LZCNSwXKDTt0/3IPdszFAqiV19MLjMK/vHDDPTlr INFVrYe/uBWMFKVPdd5S6xym0PgwHTeiwkYax+mVXGdHs9VwuNrBaWWwuU8WY5e/cmQb ZjOAU9/DHA8xjzRIw76HY/lWL/WClwMnJ59JCRmxUmZ5mhhfiGI3f/62b95Ns7ElDUDT 2v8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763153508; x=1763758308; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r5fX1MysWhFmcB+WwiW0z8iIPBJH7K9A9qIpnyNOJTI=; b=hndcNn1UBx3pxgsmtActeuo+o2FhUv+ANZzfDRogBoa9pwNZoVkj5mz8dYELPW3xVr rLzcubrR+n+NP7NkXeAZ7k13e/Yuwcgyvd1dhHR9pVFGLaiPLNLbzmRQbW0vhs38UId6 x4+0UtTgtiImOhzGqZ4PvaFlXbdkVV6qLvVt+UaX+iagfIQimnj+5MxQGfC7raugyfeA NKdaiDNSpqMoLvF2bHhStsiVoJz0v1eHFBbeygQ+vKtTRhGtPu/mGdXWyAsJ9iI1Jd0w 86XHmB5RdDbyD0LXUWmqg/CVEvSOszK1MqdTBXVYkXw0iFL+QBPejDbjji1wHlepzPU0 RXsw== X-Forwarded-Encrypted: i=1; AJvYcCVkW2JMwr9bqWVUMghb9wQKonMC6cWh6PvOQR2TdohzaDQEyuE6cfQqT8+t7w2fBFS8PKgy/581uS/Coko=@vger.kernel.org X-Gm-Message-State: AOJu0YziPBeN0yE+IW5VKUD6D0GN/+8WA99S2kd5jyq1mplbDsy69W63 JJmxRvhvzdCJ1MQi8kydhE/gqwGTIwHfVetA+srmtdir0I4zUuThB6mB8kX78zCK60Y= X-Gm-Gg: ASbGnctC6N8Kd4Nec9ZmevE5A9GXvwXWjq1avsfbjuffQca/WBA5lZi1FztvUVyjnlm N7RhgD0Mkc+D6EfwUwc+p0vYQMSEZh5y/j8Ocdqtx7LDzNBjXyj/9VgWB7NEDzfsRZaRqVP8l2C 4awkQcZ7YzxFr8hJqK+j+Nc++8sMMxszPHIHikHgq74XVe7N99g65lwlqS7H+Ralfy8R+GyiPAA 7X7XKjTN19/476IjfPW4wkZM+9vFtie/a7b2kfsYh/m3LxcvrX1Qgv2ILD04lwYBKoaHlS4CI1Z 4mZZ0gBEEtT21SSNX3egj30JLUFaDWCP84EF/x4u57tCI9CgLP0bPLTYgjPB/+xe8uegZTyWInY SrL0yd7JZ5xsWAPSdAOTnz8n/ptziCGJvXalYTuMlaVLFO8zmlvCB10mgl7dd5U8cfKF/oNK+Ig == X-Google-Smtp-Source: AGHT+IG159UiYhWVCcgUydPpcwCRAFvTjZEVsHbRkwXu7EKFm7a9S1w4iE/kFuWeNmbtfLLSP6dEbw== X-Received: by 2002:a05:6602:6d03:b0:948:75e2:dccd with SMTP id ca18e2360f4ac-948e0dcae10mr730655839f.15.1763153508234; Fri, 14 Nov 2025 12:51:48 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-948d2f8e339sm351975439f.19.2025.11.14.12.51.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Nov 2025 12:51:47 -0800 (PST) Message-ID: Date: Fri, 14 Nov 2025 13:51:46 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] block/blk-throttle: Fix throttle slice time for SSDs To: Khazhy Kumykov , Tejun Heo Cc: yukuai@kernel.org, Guenter Roeck , Josef Bacik , Yu Kuai , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250730164832.1468375-1-linux@roeck-us.net> <20250730164832.1468375-2-linux@roeck-us.net> <1a1fe348-9ae5-4f3e-be9e-19fa88af513c@kernel.org> <2919c400-9626-4cf7-a889-63ab50e989af@roeck-us.net> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 11/14/25 1:26 PM, Khazhy Kumykov wrote: > On Wed, Jul 30, 2025 at 4:19 PM Guenter Roeck wrote: >> >> On 7/30/25 11:30, Yu Kuai wrote: >> I had combined it because it is another left-over from bf20ab538c81 and >> I don't know if enabling statistics has other side effects. But, sure, >> I can split it out if that is preferred. Let's wait for feedback from >> Jens and/or Tejun; I'll follow their guidance. >> >> Thanks, >> Guenter >> > noticed this one in our carry queue... any further guidance here? If > my opinion counts, since this is a fixup for a "remove feature X" > commit... I would have done it in one commit as well :) I agree with Yu that a split of patch 1 would be appropriate. -- Jens Axboe