From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Jayesh Choudhary <j-choudhary@ti.com>,
linux-kernel@vger.kernel.org, dmitry.baryshkov@linaro.org,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Laurent.pinchart@ideasonboard.com,
mripard@kernel.org, sam@ravnborg.org
Cc: jonas@kwiboo.se, jernej.skrabec@gmail.com,
maarten.lankhorst@linux.intel.com, tzimmermann@suse.de,
airlied@gmail.com, daniel@ffwll.ch, a-bhatia1@ti.com,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v4 0/2] Add mode_valid and atomic_check hooks for sii902x bridge
Date: Fri, 31 May 2024 20:55:15 +0800 [thread overview]
Message-ID: <ba038d60-e399-476d-a4f3-50fc9d8eb390@linux.dev> (raw)
In-Reply-To: <20240530092930.434026-1-j-choudhary@ti.com>
Hi,
On 5/30/24 17:29, Jayesh Choudhary wrote:
> Move the mode_valid hook to drm_bridge_funcs structure to take care
> of the case when the encoder attaches the bridge chain with the
> DRM_BRIDGE_ATTACH_NO_CONNECTOR flag in which case, the connector is not
> initialized in the bridge's attach call and mode_valid is not called.
Good catch, as modes being supported is actually a capability of the
bridge itself. The move make the driver reflect the hardware more.
prev parent reply other threads:[~2024-05-31 12:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 9:29 [PATCH v4 0/2] Add mode_valid and atomic_check hooks for sii902x bridge Jayesh Choudhary
2024-05-30 9:29 ` [PATCH v4 1/2] drm/bridge: sii902x: Fix mode_valid hook Jayesh Choudhary
2024-05-30 23:30 ` Dmitry Baryshkov
2024-05-31 13:20 ` [v4,1/2] " Sui Jingfeng
2024-05-31 13:33 ` Sam Ravnborg
2024-05-31 14:04 ` Sui Jingfeng
2024-06-12 5:21 ` Jayesh Choudhary
2024-05-30 9:29 ` [PATCH v4 2/2] drm/bridge: Add pixel clock check in atomic_check Jayesh Choudhary
2024-05-30 9:34 ` Maxime Ripard
2024-05-30 9:50 ` Jayesh Choudhary
2024-05-31 12:55 ` Sui Jingfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba038d60-e399-476d-a4f3-50fc9d8eb390@linux.dev \
--to=sui.jingfeng@linux.dev \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a-bhatia1@ti.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=j-choudhary@ti.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox