From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933931AbdKGVLU (ORCPT <rfc822;w@1wt.eu>);
        Tue, 7 Nov 2017 16:11:20 -0500
Received: from mailout.easymail.ca ([64.68.200.34]:52161 "EHLO
        mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755310AbdKGVLR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 7 Nov 2017 16:11:17 -0500
Reply-To: shuah@kernel.org
Subject: Re: [PATCH 2/2] usbip: use monotonic timestamps
To: Krzysztof Opasiak <k.opasiak@samsung.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Valentina Manea <valentina.manea.m@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Johan Hovold <johan@kernel.org>,
        Felipe Balbi <felipe.balbi@linux.intel.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, Shuah Khan <shuahkh@osg.samsung.com>,
        Shuah Khan <shuah@kernel.org>
References: <20171107104010.2884193-1-arnd@arndb.de>
 <CGME20171107104035epcas5p3b6a2556146de0340d762701451aeb1d2@epcas5p3.samsung.com>
 <20171107104010.2884193-2-arnd@arndb.de>
 <93e30403-bfe3-9547-122b-bb4955d264be@samsung.com>
From: Shuah Khan <shuah@kernel.org>
Message-ID: <ba0a6828-1fe7-636d-ce48-61cc0f38e9a2@kernel.org>
Date: Tue, 7 Nov 2017 14:10:57 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <93e30403-bfe3-9547-122b-bb4955d264be@samsung.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/07/2017 04:22 AM, Krzysztof Opasiak wrote:
> 
> 
> On 11/07/2017 11:39 AM, Arnd Bergmann wrote:
>> This gets rid of the deprecated do_gettimeofday() function in usbip.
>> The comment above vgadget_get_frame() mentions that it suffers
>> from issues with the time jumps due to suspend and settimeofday,
>> so I'm changing it to use ktime_get_ts64() to use monotonic times
>> that don't have this problem.
>>
>> I couldn't tell whether we should use CLOCK_MONOTONIC or
>> CLOCK_MONOTONIC_RAW here, the difference being the exact rate
>> when correcting for NTP. I picked monotonic time since it doesn't
>> change the speed to the existing code and should be better
>> synchronized with other machines we talk to.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Looks good to me:
> Reviewed-by: Krzysztof Opasiak <k.opasiak@samsung.com>
> 

Acked-by: Shuah Khan <shuahkh@osg.samsung.com>

thanks,
-- Shuah