From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFEDF3D348F for ; Wed, 6 May 2026 23:43:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778110999; cv=none; b=to6BlWfFw7VpzvdPtqxn7fe8YA5oQIJMQYLMm4n4RvsRQAGGPGxOEYFk5w6tzRgZ/6+OlOBTjeHcTfy56/0zeWANb7QdX6z/mSVhKysoXPIulwPiMdY1xECsXvGw51KCP8zZ0F6X/AKnlRZqB1t7ek72DUwvv7ywks3oYWcgtXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778110999; c=relaxed/simple; bh=VrhtxDHUUeFu0o5VmnJwmZF5v65oeWz1aqO85RgV8C8=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=gzjpfqMEc011vKkDU0b3eRYlAQNPEgc7Ze0X8BMqG0jyUW1yBBx657o6KNRQS03CLzLHl57HhppF5OspAnT/4JXXUTaniRm4VHqaniiZIAGThpSfuED3vZLgBtIQk/W1ni46AUOimZviQRbi8zFtoiAsPookX6CQFDLPi/aCzaw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=Ae/wsCkH; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="Ae/wsCkH" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-8c70b5594f4so28229385a.1 for ; Wed, 06 May 2026 16:43:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1778110996; x=1778715796; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=JoTC/lw/OUWxpldadyRFLcKS56uCYY4dboDv240sPdE=; b=Ae/wsCkHlYO6nkFDB3q14KPZmWcAxXsIkn8tlmGWziI86zH6j/g93jptOfTZFWCdmY 6XWGBXWOt/fSYF4FrfHj7qYLsyIfxmHpGPL4/iaikWWqd+noPoLuuDeCwTpJKcJ1TVsh U+0UATOgx6IOFrEyoxXJ2SggOBm+GTBIIk3cH2sG5DciySfgyGRNdDPRWkGjw/WqJKXk C7bbF+ecKPDfBgYKV2Eib72s2IwXoCJ/T++Lls+LYWCx9f8FgYkrTEVgSxGif/jbCKZ0 G9EsQL4eFVPbJ3VKrGsNzqRNGgzZgpPj1fzMPLk9tM74TdihhYpwhJ1rmEIosadG49Lg KpdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778110996; x=1778715796; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JoTC/lw/OUWxpldadyRFLcKS56uCYY4dboDv240sPdE=; b=D+1tUcF2xlc33xiNhrYujuiPg4zldD0Gzcr17scXng/66MjVdon2IcE2+/gD7LVse3 DOHVOhXbKsyJLPwfo+LyPZkkfUxwE2y5Gjol640rZflL37oXUxLNbflP1yevmP2Lcp3W Azqo0vxnSxAzhJOBElesHjYfqI+pcoGdSEEx6mBbVILIGDq5rR1tlamXoH+iMxoHuhVa NR6CUJlFBPpdz4TZLS3dWoOJXF9meU4FFqLlYumFFNT3MYHPREYs/d7avojMd+gxDeAR uRkv1rDsqwV7AfHlTPbrgFPSShQgWF5Or9CK67x3BWDq/jjUzq7f/9RKVm5aM9aq7QVC vMYQ== X-Forwarded-Encrypted: i=1; AFNElJ8r8VKewp/ghZetzMTLsqfiELz/JT6fTvHqa0XfsCYFefunN9FYt4Ia5UPcvUIiYUH/rCkfkRDDzaGDd1M=@vger.kernel.org X-Gm-Message-State: AOJu0YynbpXbeqQmAYeZioA5G7sN9BwWpZeaQl20cxViaMoMZPTpzmv+ oX8SACbZdWFgGprxhaMf3B5dbfOUToLXp3K0nwFQUuNF+dxNwElvZ9pJNrs2JLsj8g== X-Gm-Gg: AeBDiesz8ggjl5w0R9hL59fJfSiX7+QvcBiNQ1/LgAouHXetFrUdDGe1Kb2mlrS/GR9 g8Q2vqSLfPjZquQ0K46AkTgy2pKUQBIHTAe7HtJWXzdtGvjg+cYBA4DY7gB3yU3H6UjTO9Yg3m4 Me9NIE3nJXIseVXqhm+VbITZFoUx66W1Sf3i38vZlCHIViYtRbiAmzhzOD+utP2hsUTO/EMH0wA l6O6rjHb3agPDfFK8RcxViCvJ5fwcWBJCcU9rekm4psdVqCmGL/EGXlF13f+5HOFiJvgMJ3/RmH 1PbJbJvRQqNTWOHDnHYuj/7wXT12qHmen61LdOK+HqVjEJwsMFc5N05tiR/azjpmVxUqenfSgje uAblMFrvGw3UmFe0IAuZgADk2edf+JXr0sSbdI3A8R8ngOcOLnRa3YU40lKiqivDUIY03ecFKVg m92DYtevO+wcwn3c7SiT06bb/zvlkNynEMTE+ndPWjzhITMdEDxqIcPNdSLZTFcfoo3whtFmQic nM3exymimzgu+rvfg== X-Received: by 2002:a05:620a:45a6:b0:8d6:6db0:88de with SMTP id af79cd13be357-90653728e7emr91239285a.44.1778110995685; Wed, 06 May 2026 16:43:15 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b53c1dc62csm211275276d6.23.2026.05.06.16.43.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 16:43:14 -0700 (PDT) Date: Wed, 06 May 2026 19:43:14 -0400 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260506_1600/pstg-lib:20260506_1556/pstg-pwork:20260506_1600 From: Paul Moore To: =?UTF-8?q?Christian=20G=C3=B6ttsche?= , selinux@vger.kernel.org Cc: =?UTF-8?q?Christian=20G=C3=B6ttsche?= , Stephen Smalley , Ondrej Mosnacek , linux-kernel@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , llvm@lists.linux.dev Subject: Re: [PATCH v3 10/14] selinux: validate symbols References: <20250511173055.406906-10-cgoettsche@seltendoof.de> In-Reply-To: <20250511173055.406906-10-cgoettsche@seltendoof.de> On May 11, 2025 =?UTF-8?q?Christian=20G=C3=B6ttsche?= wrote: > > Some symbol tables need to be validated after indexing, since during > indexing their referenced entries might not yet have been indexed. > > Signed-off-by: Christian Göttsche > Acked-by: Stephen Smalley > --- > security/selinux/ss/policydb.c | 94 ++++++++++++++++++++++++++++++++++ > 1 file changed, 94 insertions(+) ... > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index f8d6e993ce89..4559c8918134 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -765,6 +843,16 @@ static int policydb_index(struct policydb *p) > if (rc) > goto out; > } > + > + for (i = 0; i < SYM_NUM; i++) { > + if (!validate_f[i]) > + continue; > + > + rc = hashtab_map(&p->symtab[i].table, validate_f[i], p); > + if (rc) > + goto out; > + } Is there a reason why we need a second loop to do the validation? Can we simply do the validation in the indexing loop above this? for (i = 0; i < SYM_NUM; i++) { p->table[i] = kvcalloc(...); hashtab_map(p->table, index_f[i]); if (validate_f[i]) hashtab_map(p->table, validate_f[i]); } -- paul-moore.com