From: David Laight <David.Laight@ACULAB.COM>
To: 'Mark Rutland' <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
"will@kernel.org" <will@kernel.org>
Cc: He Zhe <zhe.he@windriver.com>,
"oleg@redhat.com" <oleg@redhat.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"paul@paul-moore.com" <paul@paul-moore.com>,
"eparis@redhat.com" <eparis@redhat.com>,
"linux-audit@redhat.com" <linux-audit@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat
Date: Sat, 17 Apr 2021 13:19:02 +0000 [thread overview]
Message-ID: <ba281040abc146fca5a2117d5476aa1b@AcuMS.aculab.com> (raw)
In-Reply-To: <20210416133431.GA2303@C02TD0UTHF1T.local>
From: Mark Rutland
> Sent: 16 April 2021 14:35
..
> @@ -51,13 +48,7 @@ static inline void syscall_set_return_value(struct task_struct *task,
> struct pt_regs *regs,
> int error, long val)
> {
> - if (error)
> - val = error;
> -
> - if (is_compat_thread(task_thread_info(task)))
> - val = lower_32_bits(val);
> -
> - regs->regs[0] = val;
> + regs->regs[0] = (long) error ? error : val;
= error ? (long)error : rval;
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2021-04-17 13:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 7:55 [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat He Zhe
2021-04-16 7:55 ` [PATCH 2/3] arm64: syscall.h: Add sign extension handling in syscall_get_return_value for compat He Zhe
2021-04-16 9:43 ` Oleg Nesterov
2021-04-20 8:38 ` He Zhe
2021-04-21 17:41 ` Mark Rutland
2021-04-22 16:55 ` Mark Rutland
2021-04-16 7:55 ` [PATCH 3/3] audit: Use syscall_get_return_value to get syscall return code in audit_syscall_exit He Zhe
2021-04-16 12:33 ` [PATCH 1/3] arm64: ptrace: Add is_syscall_success to handle compat Catalin Marinas
2021-04-16 13:34 ` Mark Rutland
2021-04-17 13:19 ` David Laight [this message]
2021-04-19 12:19 ` Will Deacon
2021-04-20 8:54 ` He Zhe
2021-04-21 17:10 ` Mark Rutland
2021-04-22 16:07 ` Will Deacon
2021-04-22 16:42 ` Mark Rutland
2021-04-22 18:57 ` Dmitry V. Levin
2021-04-20 8:42 ` He Zhe
2021-04-21 17:17 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba281040abc146fca5a2117d5476aa1b@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=catalin.marinas@arm.com \
--cc=eparis@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oleg@redhat.com \
--cc=paul@paul-moore.com \
--cc=will@kernel.org \
--cc=zhe.he@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox