From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932857AbdEXSEG (ORCPT ); Wed, 24 May 2017 14:04:06 -0400 Received: from mout.web.de ([212.227.15.14]:56934 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754408AbdEXSEE (ORCPT ); Wed, 24 May 2017 14:04:04 -0400 Subject: [PATCH 1/2] blackfin: Delete an error message for a failed memory allocation in bfin_pm_suspend_mem_enter() From: SF Markus Elfring To: adi-buildroot-devel@lists.sourceforge.net, Ingo Molnar , Steven Miao Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Wed, 24 May 2017 20:03:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:PaEFStT1eT1yj83CYJtb1tCUa7067bUmmKKqKkPRwMWAhlXV7fI NVTZ5T+9wpnNIfKZjKkgXBrkzW3wYjNOxMmzSU4fvYVkI8VDdMaE+UJwTrnQ1N79qYA2Q7A R8esAM16ZLYaIvhF+kJ726g6sL8rnNyXXT68XUL/ugQozaGI/gnHZtg0RUV7oZ9XgQRMDb1 Dl8Uk7bRGOp4z4wYf9tuw== X-UI-Out-Filterresults: notjunk:1;V01:K0:cWILizs808s=:yd6Y2b3OrR7mclduURon3A CwHlmCBcajqqTIbuWHI3+JFaiW3326kj/KgVd2DKHMsJf4N2jyb/GVuBkmRPR/8e0BmDoN8OW cJxxvQ+L2RhWvn5iX2JfqAsE3Y12Ivq6uF8IrBTov2022q8bsqnBfa5YRd1fxZv6UeItBAFNP WIC9cXKsJ4AiqM3IIRlR0OCqgK0ndm2wmOQi0cnYGd/9kUUpGsadJ/ROL6Vy5Anh1GuW19rRw XicVwwTxt2sejdQ92Y17t3H17W4BHVEcHpBXFgkyeXjOrfs6rhn0wFWqoUAAnsCKbUHzOCm2+ q0uEXyWaypn90lTefPaa9gIlFsquE8wy2Ermq+Ql8e93Xet1jP7Ddk4+2eS72yjsKw/6YwlMb 4MPfAXiUNBgMc5ASiea8q5fRFBfOrsFUEkuFyzxfkZd4reLCll4zGW3kYsIs+B4iT+8A3bpm8 YGOTPyIhvsAz9pY5w28I+K/PN2sBvIHiaL2ZWiNszp+uG7FJYjSQi6UplmIYAcdfngcX3n9bC UkirNf+ENX1OkDiYYCDFE2/yPvETguznnWibTElfBpEQeJgN4c9dSNXxrjh0OeZ/IR/dDqNzc 5usE+To4maxpiGsJzp+OHdn+I2xYhn93iRtGIbA/93il4vcmCYABAXXYpJKT15nuIxesehBpu 8lCknQVvxa0Fme4dvS21PWRYKtei6ukkdO7koDnK2pIrqIL34G0cxtJVd/lIWU4sR/Ce/kg1w RVprZfvUS86k6T7EkbbbqrMkNK/yLgkbcKWE2nAjy/5jO7vcRVyqTJ8DTjn+ltWTBVovKpsgg UY96/j0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 24 May 2017 19:29:25 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- arch/blackfin/mach-common/pm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/blackfin/mach-common/pm.c b/arch/blackfin/mach-common/pm.c index 5ece38a5b758..f4d442b7a1a1 100644 --- a/arch/blackfin/mach-common/pm.c +++ b/arch/blackfin/mach-common/pm.c @@ -151,10 +151,8 @@ int bfin_pm_suspend_mem_enter(void) + L1_DATA_B_LENGTH + L1_SCRATCH_LENGTH, GFP_ATOMIC); - if (memptr == NULL) { - panic("bf53x_suspend_l1_mem malloc failed"); + if (!memptr) return -ENOMEM; - } #ifndef CONFIG_BF60x wakeup = bfin_read_VR_CTL() & ~FREQ; -- 2.13.0