From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0C27E3EB81B for ; Tue, 14 Jul 2026 15:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784043737; cv=none; b=BsTSGAzSaNWus5p6WBx1JhC/JQ+EN8oWAVhKXCducjDM42jqsk/mlAxtOyndm0Ye8MfOQxrXtv3EFu02VbVXmSxphNXQozmupeb4gP/HCeA7Sar9m/HhZLAzYJOKaj84munWF4FFRTg/gyOD+62A+S3Q9Eo/yiVbAEOCPvC6JaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784043737; c=relaxed/simple; bh=mtQi5H8RwPqcAfX+tMPn90SP46CQifKMBSHfHMkHGz0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Ob/93AROMkm5LUKIcJIEjc5a0S2eQztOJVzj9/PY5uTdIU/m2XB+eekia2z6ZWN+Yht8A2HK5sGiR3xGQdXeXy+FySUIp/0kegNHaqxvvsANd0mhM16IDFaUeFSlwj5nKzjBaYiYFNzLehCgaLMrsh8mKqT2vjt74tQvOPo0T+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RCn/6lhz; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RCn/6lhz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEB9D1F000E9; Tue, 14 Jul 2026 15:42:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784043735; bh=hw/GZ8sZpK+8U70Cy1Nb/z5CpTUfbrL8cZQu/aoFn14=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=RCn/6lhzugIh3KOvzkWnO7fmMiOJkMPuoc8O5LC40STlvH8RA8BR2h3NhLhJfwAON kiMgkZtg7EYfgTQz/GXzTzXHjTTquIaYTwkMT3jJXYDh4VmBrNW1xvC3wcv2lgfMN0 xN/+i1QAN47zqnJK3Mrod5M0XzFdcMUkRDh9QXOYi6BKW0yUGlhcOmfagnlUCa82nA 84DFV8yOusVilPmKvx6kOhOlpzgVnSXs1xI5apl7ZO99oRWByskzZHl+kKBuLq6V92 1dwDlmXI7TCErdZ4xRmRrqwuJMfJy+HpLDPUOj97gUgvK/UGb7RmJcCe9dfTKsgD3/ PSClyydLsCITg== Message-ID: Date: Tue, 14 Jul 2026 17:42:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH slab/for-next-fixes v3 0/4] mm/slab: fix unbounded recursion in free path with memalloc profiling Content-Language: en-US To: "Harry Yoo (Oracle)" , Andrew Morton , Hao Li , Christoph Lameter , David Rientjes , Roman Gushchin , "Liam R. Howlett" , Suren Baghdasaryan , Hao Ge , Kees Cook , Pedro Falcato , Shakeel Butt , Danielle Constantino Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260713-kmalloc-no-objext-v3-0-47c7bd138de7@kernel.org> From: "Vlastimil Babka (SUSE)" Autocrypt: addr=vbabka@kernel.org; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSNWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBrZXJuZWwub3JnPsLBsAQTAQoAWhYhBKlA1DSZLC6OmRA9UCJPp+fM gqZkBQJqFFy6GxSAAAAAAAQADm1hbnUyLDIuNSsxLjEyLDIsMgIbAwUJGtCBUAULCQgHAwUV CgkICwUWAgMBAAIeBQIXgAAKCRAiT6fnzIKmZJIUEADFx/tREzUImHrEwVHeSvDFmA7tJysI UVrlvrM09E7GIuzphzv7jYmo8n3ANpCczLEVr4G0syYQdTigaZgv3+FQDIIzhKih1IHhu1Ei XHlywNWKnQxxQEUNi5Mwx43wQz5XVw9F1A7gtKBKNtfogO511hAbrzagrYajyQacEJ/+sfhZ 9Da8ltHIXD8pcYaHUfQgEusCgmEd9+KrUwrTbckFKmYq5chuE6yJ4J0EmWknL096jIE6CnzF FRslQ3B1UKDjxVsm1ZHfir5NeWszLkTvGFsddFaWTgh8UycESG6VQzKXjjewXu2pG7YQYRpj QKm1W5X2TkwWkXRBZTmfmbhxIUMh3+zf5wQ463rSmDN/8v81tdqBtAW6rH/kzg1GvkaTHXn0 507yEHFzBksk2viAuIxxr7km8+/KARYLIdGtx30EG8cKzAUZOK6WqxtNCsXUJNrVE8CWrCaD icoNu7Fs1c5hmPHdSTnU48ce67449DdnO4neLSNhRiGlMHJgfJUmgrxu/hcYeOZ3haWmEQ2w uW1Mh01OHi8QZHCEyAbABrPs9GUgccc/4eYXX9hIgxfSkYzn8f+8NuIFPWl/0uTvjgqU29FQ SbzOLxHq9439Ox40G5mS5eZXRGxITYR+6TXvRGI6P/264jvflnr/pDGUttaikU+0W+1uxgKH cmYbEc7ATQRbGTU1AQgAn0H6UrFiWcovkh6EXVcl+SeqyO6JHOPm+e9Wu0Vw+VIUvXZVUVVQ La1PQDUi6j00ChlcR66g9/V0sPIcSutacPKfdKYOBvzd4rlhL8rfrdEsQw5ApZxrA8kYZVMh FmBRKAa6wos25moTlMKpCWzTH84+WO5+ziCTsTUZASAToz3RdunTD+vQcHj0GqNTPAHK63sf bAB2I0BslZkXkY1RLb/YhuA6E7JyEd2pilZOrIuBGl/5q2qSakgnAVFWFBR/DO27JuAksYnq +aH8vI0xGvwn75KqSk4UzAkDzWSmO4ZHuahKtQgZNsMYV+PGayRBX9b9zbldzopoLBdqHc4n jQARAQABwsF8BBgBCgAmAhsMFiEEqUDUNJksLo6ZED1QIk+n58yCpmQFAmfIHFQFCRYU6J8A CgkQIk+n58yCpmS2PA//bqN1LfcotmArgElsa+0EGZSQlYgK48pm8WAeTXTngudP9IJ4SuKY HR5RNjHcBeqN+Me0zxRqYzRb8nGanHEkDyf4Im8DQM8d6vbyU+FcPmG4skud4kgS1zMHnlVd SXfSIwKC/hKgdHG8aBV7545Lz9X6Iohea+94wneD0aw/hqF+QWewGZhWJriWAZtvEkzNjQOi 4U9F/trLten/x7bpphDSnDMKJtITbtzATT1Dq7o7VpIUK1nCTQALMuMjKCdi8OdU/+V+R3O4 0PXWvX8qrvqYapVbZ+9KqT74FsuB0Ya9uXwgBF2Q6cRuETZk5vqaqKxzqoQZCO8AOz/58j6O 2RHNy/mZEN+7tJ5Tsq42zVJ4jxsT8b9YplavCMsnBgDeRWhcbYhCyttoL7nYISyWg4kQYZ/P wIV3OuNv2f8iKYsxNsRuClOAF82+gvqOy1/1pprFjy8uo2pkoOrb63aOP3vO5VHnRKgra6dq NcaZ+c6J4H+nEJGi2SkHAUJz5oBzuThvPudLvPA/SK8sKoM01IRxSihev/S/5WLazXB1PGem OCbvzC1IjWJJraxiDJ5IygokapUa2RP7+WBR22skQ3SSl6G107QgWKSyTOGWEaRmV53vxQLV jXuCmzSSasTL60zq5yGrT4/DYQVSNEUiUbG4pYekxJujNeEDkUlky0Y= In-Reply-To: <20260713-kmalloc-no-objext-v3-0-47c7bd138de7@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/13/26 16:28, Harry Yoo (Oracle) wrote: > This is a follow-up fix after the recent discussion [1]. > See patch 4 for the detailed description on the bug. > > Based on slab/for-next-fixes (af9ea231c0b45) and is available at > git.kernel.org [2]. > > Instead preventing cycles by bumping up the allocation size of obj_exts > arrays, it introduces a new kmalloc type called KMALLOC_NO_OBJ_EXT and > disallow formation of cycles between kmalloc types when allocating > obj_exts arrays. obj_exts arrays of normal kmalloc caches are served > from KMALLOC_NO_OBJ_EXT caches (that don't have obj_exts), and all other > obj_exts arrays are served from normal kmalloc caches. > > I tried to reuse SLAB_ALLOC_NO_RECURSE to make kmalloc_slab() select > KMALLOC_NO_OBJ_EXT, but it was not great because it does not allow > sheaves for those caches. So I introduced a new slab alloc flag > SLAB_ALLOC_NO_OBJ_EXT. > > To avoid huge confusion, I had to decouple "disallowing sheaves" > semantics from SLAB_NO_OBJ_EXT and introduced SLAB_NO_SHEAVES. > > While this cannot be directly backported to v6.18 and v6.12 due to lack > of SLAB_ALLOC_* flags and kmalloc_flags(), I don't this will be > particularily challenging to backport it. Instead of a new slab alloc > flag, we can use __GFP_NO_OBJ_EXT to select KMALLOC_NO_OBJ_EXT as > kmalloc caches don't have sheaves in v6.18 anyway. > > [1] https://lore.kernel.org/linux-mm/9a139365-28e6-4f1e-b35b-7f6091e9aa14@kernel.org > > [2] https://git.kernel.org/pub/scm/linux/kernel/git/harry/linux.git/log/?h=kmalloc-no-objext-v3r1 > > To: Vlastimil Babka > To: Andrew Morton > To: Hao Li > To: Christoph Lameter > To: David Rientjes > To: Roman Gushchin > To: Suren Baghdasaryan > To: Hao Ge > To: Kees Cook > To: Pedro Falcato > To: Shakeel Butt > To: Danielle Constantino > To: Liam R. Howlett > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Harry Yoo (Oracle) Added to slab/for-next-fixes, thanks! I've removed Fixes: and Cc: stable from patches 2 and 3 as I don't believe it's the way to handle the dependencies.