From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Jonathan Marek <jonathan@marek.ca>, freedreno@lists.freedesktop.org
Cc: Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Konrad Dybcio <konradybcio@kernel.org>,
"open list:DRM DRIVER for Qualcomm display hardware"
<linux-arm-msm@vger.kernel.org>,
"open list:DRM DRIVER for Qualcomm display hardware"
<dri-devel@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/msm/dsi: improve/fix dsc pclk calculation
Date: Sat, 5 Oct 2024 18:31:09 +0200 [thread overview]
Message-ID: <ba56c822-cf3d-4d62-86d4-e04551e443c6@oss.qualcomm.com> (raw)
In-Reply-To: <20241005143818.2036-1-jonathan@marek.ca>
On 5.10.2024 4:38 PM, Jonathan Marek wrote:
> drm_mode_vrefresh() can introduce a large rounding error, avoid it.
>
> Signed-off-by: Jonathan Marek <jonathan@marek.ca>
> ---
> drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
> index 185d7de0bf376..1205aa398e445 100644
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -542,7 +542,7 @@ static unsigned long dsi_adjust_pclk_for_compression(const struct drm_display_mo
>
> int new_htotal = mode->htotal - mode->hdisplay + new_hdisplay;
>
> - return new_htotal * mode->vtotal * drm_mode_vrefresh(mode);
> + return mult_frac(mode->clock * 1000u, new_htotal, mode->htotal);
This seems to ignore mult/div by two on certain mode flags.. is that
intended?
Konrad
next prev parent reply other threads:[~2024-10-05 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-05 14:38 [PATCH 1/2] drm/msm/dsi: improve/fix dsc pclk calculation Jonathan Marek
2024-10-05 14:38 ` [PATCH 2/2] drm/msm/dsi: fix 32-bit signed integer extension in pclk_rate calculation Jonathan Marek
2024-10-06 17:32 ` Dmitry Baryshkov
2024-10-05 16:31 ` Konrad Dybcio [this message]
2024-10-05 16:55 ` [PATCH 1/2] drm/msm/dsi: improve/fix dsc pclk calculation Jonathan Marek
2024-10-06 17:32 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba56c822-cf3d-4d62-86d4-e04551e443c6@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox