From: Jens Axboe <axboe@kernel.dk>
To: Tejun Heo <tj@kernel.org>, Jan Kara <jack@suse.cz>
Cc: linux-block@vger.kernel.org, kernel-team@fb.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 block 1/2] writeback, cgroup: Adjust WB_FRN_TIME_CUT_DIV to accelerate foreign inode switching
Date: Thu, 15 Aug 2019 13:31:02 -0600 [thread overview]
Message-ID: <ba595b28-3669-d16f-07de-d05c6164dee5@kernel.dk> (raw)
In-Reply-To: <20190815192528.GA2240241@devbig004.ftw2.facebook.com>
On 8/15/19 1:25 PM, Tejun Heo wrote:
> WB_FRN_TIME_CUT_DIV is used to tell the foreign inode detection logic
> to ignore short writeback rounds to prevent getting confused by a
> burst of short writebacks. The parameter is currently 2 meaning that
> anything smaller than half of the running average writback duration
> will be ignored.
>
> This is unnecessarily aggressive. The detection logic uses 16 history
> slots and is already reasonably protected against some short bursts
> confusing it and the current parameter can lead to tens of seconds of
> missed detection depending on the writeback pattern.
>
> Let's change the parameter to 8, so that it only ignores writeback
> with are smaller than 12.5% of the current running average.
>
> v2: Add comment explaining what's going on with the foreign detection
> parameters.
Applied 1-2 for 5.4, thanks.
--
Jens Axboe
prev parent reply other threads:[~2019-08-15 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 19:07 [PATCH block 1/2] writeback, cgroup: Adjust WB_FRN_TIME_CUT_DIV to accelerate foreign inode switching Tejun Heo
2019-08-02 19:08 ` [PATCH block 2/2] writeback, cgroup: inode_switch_wbs() shouldn't give up on wb_switch_rwsem trylock fail Tejun Heo
2019-08-15 13:53 ` Jan Kara
2019-08-15 13:48 ` [PATCH block 1/2] writeback, cgroup: Adjust WB_FRN_TIME_CUT_DIV to accelerate foreign inode switching Jan Kara
2019-08-15 19:25 ` [PATCH v2 " Tejun Heo
2019-08-15 19:31 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba595b28-3669-d16f-07de-d05c6164dee5@kernel.dk \
--to=axboe@kernel.dk \
--cc=jack@suse.cz \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox