Re: [PATCH v17 02/10] fs/ntfs3: Add initialization of super block

Kari Argillander
2021-01-20T07:21:38Z

On Tue, Jan 19, 2021 at 06:03:06AM +0200, Kari Argillander wrote:
> On Thu, Dec 31, 2020 at 06:23:53PM +0300, Konstantin Komarov wrote:
> > diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c

> > +struct ntfs_fnd *fnd_get(struct ntfs_index *indx)
> > +{
> > + struct ntfs_fnd *fnd = ntfs_alloc(sizeof(struct ntfs_fnd), 1);
> > +
> > + if (!fnd)
> > + return NULL;
> > +
> > + return fnd;
> > +}
>
> This should be initilized. What about that indx. Is that neccasarry?
> Also no need to check NULL because if it is NULL we can just return it.

Sorry about initilized part. Didn't notice it was kzalloc. Other parts
are still relevent.