Re: [PATCH 5/6] iommu: init pasid array while doing domain_replace and iopf is active

Baolu Lu
2024-09-12T11:22:36Z

On 2024/9/12 16:25, Joel Granados wrote:
> /**
> * iommu_attach_group_handle - Attach an IOMMU domain to an IOMMU group
> * @domain: IOMMU domain to attach
> diff --git i/drivers/iommu/iommufd/fault.c w/drivers/iommu/iommufd/fault.c
> index ea7f1bf64892..51cb70465b87 100644
> --- i/drivers/iommu/iommufd/fault.c
> +++ w/drivers/iommu/iommufd/fault.c
> @@ -189,8 +189,15 @@ static int iommufd_init_pasid_array(struct iommu_domain *domain,
> if (!handle)
> return -ENOMEM;
> handle->idev = idev;
> + handle->handle.domain = domain;
> +
> + mutex_lock(&group->mutex);
> + ret = xa_insert(&group->pasid_array, IOMMU_NO_PASID, handle, GFP_KERNEL);
> + mutex_unlock(&group->mutex);
> +
> + if (ret == -EBUSY)
> + ret = 0;
>
> - ret = iommu_init_pasid_array(domain, group, &handle->handle);
> if (ret)
> kfree(handle);

This is supposed to be done automatically when an iopf capable domain is
attached to or replaced with a device. Please refer to
iommufd_fault_domain_attach_dev() and
iommufd_fault_domain_replace_dev().

Is there anything preventing this from happening?

Thanks,
baolu