Re: [PATCH v4 2/2] arm64: dts: add support for NXP i.MX8MP FRDM board

Krzysztof Kozlowski
2025-11-10T20:12:58Z

On 09/11/2025 22:45, Rogerio Pimentel wrote:
> The FRDM-i.MX8MP is an NXP development platform based on the i.MX8M Plus
> SoC, featuring a quad Cortex-A53, Cortex-M7 co-processor, 4GB LPDDR4,
> 32GB eMMC, Wi-Fi 6/Bluetooth 5.4/802.15.4 tri-radio, Ethernet, HDMI/MIPI
> display interfaces, camera connectors, and standard expansion headers.
>
> Based on the device tree found in the NXP repository at github
> https://github.com/nxp-imx-support/meta-imx-frdm and on imx8mp-evk
> board kernel mainline device tree.
>
> This is a basic device tree supporting:
>
> - Quad Cortex-A53
> - 4GB LPDDR4 DRAM
> - PCA9450C PMIC with regulators
> - Two NXP PCAL6416 GPIO expanders
> - RGB LEDs via GPIO expander
> - I2C1, I2C2, I2C3 controllers
> - UART2 (console) and UART3 (with RTS/CTS)
> - USDHC3 (8-bit eMMC)
> - SNVS power key (onboard power button)
>
> Signed-off-by: Rogerio Pimentel <rpimentel.silva@gmail.com>
> Signed-off-by: Xiaofeng Wei <xiaofeng.wei@nxp.com>

Incorrect DCO chain. Please look at submitting patches which explain
what is DCO and how it should be organized.

> ---
>
> Changes in v4:

> +
> + pinctrl_pmic: pmicgrp {
> + fsl,pins = <
> + MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03 0x000001c0
> + >;
> + };
> +
> + pinctrl_pcal6416_0_int: pcal6416_0_int_grp {

Don't use underscores in node names. See DTS coding style.

Best regards,
Krzysztof