From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753538AbdKXMwA (ORCPT ); Fri, 24 Nov 2017 07:52:00 -0500 Received: from mout.web.de ([212.227.15.3]:51479 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751679AbdKXMv6 (ORCPT ); Fri, 24 Nov 2017 07:51:58 -0500 Subject: Re: ASoC: da7218: Use common error handling code in da7218_of_to_pdata() To: Adam Thomson , "alsa-devel@alsa-project.org" , support.opensource@diasemi.com Cc: Jaroslav Kysela , Liam Girdwood , Mark Brown , Takashi Iwai , LKML , kernel-janitors@vger.kernel.org References: <07c631e4-e2df-7ae2-ea31-9430c89dc8e3@users.sourceforge.net> <32a4c9e8-2030-c4e8-eb54-9ce6712ef0cd@users.sourceforge.net> <2E89032DDAA8B9408CB92943514A0337014C1B11E5@SW-EX-MBX01.diasemi.com> From: SF Markus Elfring Message-ID: Date: Fri, 24 Nov 2017 13:50:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <2E89032DDAA8B9408CB92943514A0337014C1B11E5@SW-EX-MBX01.diasemi.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:zOCR+vD8hPNGydKOnYrsrYWNVmW1eYN0/GHmHxKzJWo7MoBKraN XNiynahNZVYe+wzXVlqy/HeIc+R1VChuIW/hDPW9MosRSvegSytcAMAyCZC+AGj1qrH2qXd w+KxOBg1lw71sO7xF+A9OVLDCWHkqD3JSUC/Ox9+ifY7jUvNLw0a4N7oV9tczOtLlFCFkPl 8H6avo2HkX7kQvXNyv7wQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:+/8Cx0BdvwM=:RcIYE39FgKO/IcuG1CZ1UO MGwgQ0Zqm/2ytjso4i7g6V/+NPUl0X69w1HsZMi/VuvEGT9ySHPT75uE4l5PqNfiAMInHs9Kr +z7PD59sngcdUZ9iU/d5j/6GmRMRhVSKghVSbjEXRfDa148yEppxecYGTGT194cFYGQTd7KR+ d3xUA3RGWRrzrC4fcMLK7DdQanW3O2Y0AEO2Km1T/QcCXIEjeNCA3+gh/NzQs+o0cs6+rpvt+ t7xaOVhaiX6A5nM1d+AiUn+MDGPOqVXrIbwnNxGJkK57ZWn6VqsIHvcHWIqbxGvID4N1+mvX2 5cUx12YSr58RyM0O8MTmr7T0tiKw1RW/zNztqOBzkWMVHBL/59MLUdDTHspsxU0z6n8QbZ6L6 D6rliRc62dXbnzV/lPOSWXilHqsSxvXJvw+MZIqgqZC1v8Nuh35K47HjVD+AtiM+vIm8idTR0 e2ZZGHaIMjdt7rSJqOYCJMakJU6GRniPehcnPQm0uw4Fjsj5KLUnuY128m15RKPEX3uUiElBs AP59Oy+eAM9Fdl3GFh9AQLFEppul2hmNztSIj1FUPcQWZU3LAiIyt4hEczREiTLQ3cSUN2ueC gjoLVhNVjhiYWbYmnegqhvre+WEkWT1QiFUFEuQly4snig2+sN+TBDFqv8f6fY8+7d+6Ccf5m qulnola2ZL8ckze5pRrzpOBSI5oixeQ1CP5z2wkldR24/dkRzuhPFVioer6bY3CJI9Kqw47/S P+xwCR7VczkLEgcU3YJHncv2P12rc72p27jDd394DKc4ZQAqqlhrJaQwa0JbYhcDoToW4RTAX tSvSyYefNnYLXKXDbc1GEynvMNk/ylyCVgHllMQtMNcSim6kY5WnxyMFezsP9nkmOC+7eae Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Add a jump target so that a bit of exception handling can be better reused >> in an if branch of this function. … > Hmm. Doesn't really gain an awful lot this. I show just another small change possibility. > Would understand if there were multiple return paths, > but in that case I'd have implemented something like this anyway. Where? Can the suggested software refactoring become useful also for this function implementation? > Also your patch description isn't really correct. Which wording would you find more appropriate? > You're re-using code from the sunny day scenario to handle an exception. Can this detail be better? Regards, Markus