From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D464EC433DF for ; Thu, 6 Aug 2020 19:48:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D53D52086A for ; Thu, 6 Aug 2020 19:48:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596743315; bh=1nahwTrMArZelmC+WxPZ+mLta7T5whOYFxnf/IoMp4w=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=MRNgm022JtNvRyMBqAVBdNI/vzFNluzHVAoOZ021isBSdgsq8Y7zudKme6dWtFnZ7 kzpUW7IT5emFVU035P5f44sd7ift3u0zFsTxYoQ1Rh9OAAz7zQXPgkqVyxFANyDROm OBhG5fsRlb9kCy9b8DhVSwA6k4ChfSRzqsxxaeo4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726346AbgHFTse (ORCPT ); Thu, 6 Aug 2020 15:48:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726093AbgHFTsb (ORCPT ); Thu, 6 Aug 2020 15:48:31 -0400 Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F3CBC061575 for ; Thu, 6 Aug 2020 12:48:31 -0700 (PDT) Received: by mail-oi1-x244.google.com with SMTP id 25so20409136oir.0 for ; Thu, 06 Aug 2020 12:48:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4gQ75ruoSOCI+/ZqdsWxnLpvjWBjTukbDtC3AHZ8rTg=; b=HL+bKaZ+qVQ7F1TeHaJfo1vBm5yKb7vlf1+/xmjhLCt38vp7sIy8YHm32APcZNMHRZ Pk8848zPgRvrItpKjsDLfhlQ1I97F12VaL4ybd3Bg/rAwX6FnS3hld18jW4QXK7VUVmH CrDQcIQQ0hIDhPm5bXwQw+0rHRPZ7idk5LuXI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4gQ75ruoSOCI+/ZqdsWxnLpvjWBjTukbDtC3AHZ8rTg=; b=X9CGa9g/kPK90FQbuDOGVJD9Dd34GWl4niFcvZO55U2xiHGT06nGMc1DE141twGKb1 cFz/6Y5lpMkq3cJdqijKeT6rKhpuqH+haE9SpUEYnSjm74F7cLcjTGZFDrmWCfkCTPXc vOIAEYHt04T5Bti8QDCjJO4Mjb/Zm0FFJjxZm/nai7vmPitOQNi4myvNWxH8Y1mqWzgF /J9sEM/j1DMDskmdCinMdaBdkRhZmbhbCmjCRW6FxprThaYPuwcIbGS1ncaRBZzK6OUu P1AFLO8zfQ5Bayr6rXM7jKT5/bRasm1SD8B3JXwvj9u1Q1tP1sDpjtHc28gT1W3s5jEx lRdQ== X-Gm-Message-State: AOAM532zyqKGdZNusuj0KKQI9PksDQm1+/5bhLD4AGfd3CEYGrb/MLjW VgLTXUiwGw6pMK2lNJxncywvxQ== X-Google-Smtp-Source: ABdhPJw21Tec6i06lnsFmCKGZ+xmQIMhPfqdJ0RZ3DidumVLHLn1K9s9oALDXkGudqsb5SkM+Xo+0g== X-Received: by 2002:aca:b106:: with SMTP id a6mr8160402oif.46.1596743308916; Thu, 06 Aug 2020 12:48:28 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id 63sm1190607otp.39.2020.08.06.12.48.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2020 12:48:27 -0700 (PDT) Subject: Re: [PATCH] scripts: add dummy report mode to add_namespace.cocci To: Greg Kroah-Hartman Cc: Matthias Maennich , Julia Lawall , linux-kernel@vger.kernel.org, kernel-team@android.com, YueHaibing , jeyu@kernel.org, cocci@systeme.lip6.fr, stable@vger.kernel.org, skhan@linuxfoundation.org References: <20200604164145.173925-1-maennich@google.com> <20200622080345.GD260206@google.com> <0eda607e-4083-46d2-acb8-63cfa2697a71@linuxfoundation.org> <20200622150605.GA3828014@kroah.com> From: Shuah Khan Message-ID: Date: Thu, 6 Aug 2020 13:48:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/22/20 10:14 AM, Shuah Khan wrote: > On 6/22/20 9:06 AM, Greg Kroah-Hartman wrote: >> On Mon, Jun 22, 2020 at 08:46:18AM -0600, Shuah Khan wrote: >>> On 6/22/20 2:03 AM, Matthias Maennich wrote: >>>> On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote: >>>>> On 6/4/20 1:31 PM, Julia Lawall wrote: >>>>>> >>>>>> >>>>>> On Thu, 4 Jun 2020, Matthias Maennich wrote: >>>>>> >>>>>>> When running `make coccicheck` in report mode using the >>>>>>> add_namespace.cocci file, it will fail for files that contain >>>>>>> MODULE_LICENSE. Those match the replacement precondition, but spatch >>>>>>> errors out as virtual.ns is not set. >>>>>>> >>>>>>> In order to fix that, add the virtual rule nsdeps and only >>>>>>> do search and >>>>>>> replace if that rule has been explicitly requested. >>>>>>> >>>>>>> In order to make spatch happy in report mode, we also need a >>>>>>> dummy rule, >>>>>>> as otherwise it errors out with "No rules apply". Using a >>>>>>> script:python >>>>>>> rule appears unrelated and odd, but this is the shortest I >>>>>>> could come up >>>>>>> with. >>>>>>> >>>>>>> Adjust scripts/nsdeps accordingly to set the nsdeps rule >>>>>>> when run trough >>>>>>> `make nsdeps`. >>>>>>> >>>>>>> Suggested-by: Julia Lawall >>>>>>> Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck >>>>>>> failed") >>>>>>> Cc: YueHaibing >>>>>>> Cc: jeyu@kernel.org >>>>>>> Cc: cocci@systeme.lip6.fr >>>>>>> Cc: stable@vger.kernel.org >>>>>>> Signed-off-by: Matthias Maennich >>>>>> >>>>>> Acked-by: Julia Lawall >>>>>> >>>>>> Shuah reported the problem to me, so you could add >>>>>> >>>>>> Reported-by: Shuah Khan >>>>>> >>>>> >>>>> Very cool. No errors with this patch. Thanks for fixing it >>>>> quickly. >>>> >>>> I am happy I could fix that and thanks for confirming. I assume your >>>> Tested-by could be added? >>> >>> Yes >>> >>> Tested-by: Shuah Khan >>>> >>>> Is somebody willing to take this patch through their tree? >>>> >>> >>> My guess is that these go through kbuild git?? >> >> If you want to take this, that's fine with me.  But as I had the >> original file come through my tree, I can take it too.  It's up to you, >> either is ok with me. >> > > Great. Please take this through your tree. > Greg! Looks like this one didn't make it in. Can you pick this up? thanks, -- Shuah