From: Dave Hansen <dave.hansen@intel.com>
To: Adam Dunlap <acdunlap@google.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
David Hildenbrand <david@redhat.com>,
Mike Rapoport <rppt@kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Nikunj A Dadhania <nikunj@amd.com>,
Dionna Glaze <dionnaglaze@google.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Joerg Roedel <jroedel@suse.de>, Jacob Xu <jacobhxu@google.com>
Subject: Re: [PATCH] x86/sev-es: Do not use copy_from_kernel_nofault in early #VC handler
Date: Thu, 7 Sep 2023 15:45:01 -0700 [thread overview]
Message-ID: <baf98f4e-0d3a-ac6f-040f-7e578525c7f7@intel.com> (raw)
In-Reply-To: <CAMBK9=ZY7UapTq3YxbjD5vhynBou_s9m4tK=oL-wfv-BoAXQ+g@mail.gmail.com>
On 9/7/23 15:30, Adam Dunlap wrote:
>> In any case, the most straightforward way out of this mess is to
>> just move boot_cpu_data out of .bss and explicitly initialize it
>> along with some documentation explaining the situation.
> That seems totally reasonable. I tried applying the two patches that
> you sent plus boot_cpu_data.x86_virt_bits = 0; in early_setup_idt(),
Let's just initialize boot_cpu_data to zero and get it out of .bss entirely.
> and that fixes the problems that we can see. Do you want me to send
> out a new patch with these changes together?
Well, ideally broken out in a couple of patches, but yeah, please resend
also with some revised changelogs based on what you've learned.
next prev parent reply other threads:[~2023-09-07 22:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 22:45 [PATCH] x86/sev-es: Do not use copy_from_kernel_nofault in early #VC handler Adam Dunlap
2023-09-06 23:01 ` Dave Hansen
2023-09-06 23:25 ` Adam Dunlap
2023-09-07 17:04 ` Dave Hansen
2023-09-07 18:03 ` Adam Dunlap
2023-09-07 19:12 ` Dave Hansen
2023-09-07 22:30 ` Adam Dunlap
2023-09-07 22:45 ` Dave Hansen [this message]
2023-09-08 13:13 ` Tom Lendacky
2023-09-08 14:48 ` Dave Hansen
2023-09-08 15:13 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=baf98f4e-0d3a-ac6f-040f-7e578525c7f7@intel.com \
--to=dave.hansen@intel.com \
--cc=acdunlap@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dionnaglaze@google.com \
--cc=hpa@zytor.com \
--cc=jacobhxu@google.com \
--cc=jroedel@suse.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox