From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 134E43542CF for ; Wed, 6 May 2026 16:28:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778084907; cv=none; b=VyX7VY6jQnLDY9/ASS9xgQC/9W04bfBV/r55SW77tpyl0Ls56WXiF+/E6guiwi1+fgDPzpKVKXB4WYimqTqYx2MsI0bm/g58a4CpPCzXIi7caBaWdkcDpp8cHdv254IkUQcxOABb8bvuUrrnJh4L+0B+AScJ/o+2TdBbriQM78w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778084907; c=relaxed/simple; bh=QYVtzd/xc7fLQtZMy6ElulTvtzvDpcvThePe9t+u1iU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NFDD0qb98lLL2swOs9Nh5XrIPbBuyCIh+LK/F+NDFlqeOMG55CIwz0J0JmiXCD0YzU3MS8rgn6YI9DllPN0eFYNSZmD8e9BxqcUQR81kJ5DkLS+QCaTtqipCtDmmn1jMbLjZmBsJF+vWMthR1C1yMvsRljDWTsPPZ8d/pfYUlNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m+4PBVCj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TXIWUcjo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m+4PBVCj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TXIWUcjo" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 646CYOKF1514824 for ; Wed, 6 May 2026 16:28:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QYVtzd/xc7fLQtZMy6ElulTvtzvDpcvThePe9t+u1iU=; b=m+4PBVCjRBUt8x9Y 1V4nTnB8Xt8sh0FUCkGcY6iMdibhGGM6ZCSfLGsXjpgwBpzNbBJqfigCaWNSfgA7 fkdoh+95AtuqpBEhTd4EwB7rt0ZSCnDVfYLZZynMPrtVmBJ/T/4FbcTnyMONpYnc +cEoGx1eBHT7GJKL402X4JQZBh5EQbW8kUGja2razBFLZB6Rq+ukNtNi6hgH29Df 8Ug154SyyiHoBpX2pDqdVJlyBC1pVPJdANWUFRjVzVSXtnGhabx8y7im4iDrkjHr es8/Uq90zcIswIcITlJGHHgJ5P/92WUd/S+EJT/Zq+X/JC5QwcAG1uOBmgvwWdMY 6x0MhQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e00v1ta52-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 06 May 2026 16:28:25 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b9fe2d6793so75481755ad.0 for ; Wed, 06 May 2026 09:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778084904; x=1778689704; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QYVtzd/xc7fLQtZMy6ElulTvtzvDpcvThePe9t+u1iU=; b=TXIWUcjoe4geql5Ai417M/q/XK+yCH9Brllg6CiYIi4BFM89EJ+YzUuiSRRxqctTS0 vwIfbTDaXvT/84wLp/EqADvKPXUxYXTecgvpD3iR8fmN3+0BESOh/CRrN/88/pLf/gsg swemlmejF74r1Yo5hhsXfnPmks2+g7ztjcKZ4oDNH0vysp52BIVrZA1K2kZ/orPi/7sJ MADndAQCS39fPlDk7opAd3Pd+GvlccB1HfELfI16lt8+5cAsJU0IQkFU8s39g2LjOj32 GSWTYRdx0HymVmp8X2zrMRbqQXCwJYxRz2fAaCbziRCl28bXtBDVI7ieVFMF19MaTKEr MOiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778084904; x=1778689704; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QYVtzd/xc7fLQtZMy6ElulTvtzvDpcvThePe9t+u1iU=; b=oQ6rRuRzFVY0nasCxrEhabzxgWpQ6FW1qUcJVpRuv2qoHAucpVjYjEcLJzZgGIhMYR YF5FgtFxZGuKL4T6gsU0ZztJAW92MGkm5twDzAVo1qq19e4BogXWF/hXAGkPnm+71qed xYbdUgG0LEsoo1SrApvkByTSY3AGW/FM6LoHZ82Slc1vA3GZdPt53PJ+Wtg+wvUW4waS iwmYzy5+d/085GjqrZNwG7z+FuVK8fP8+fzzaTdSKlj/JoL5ZtK3Y+tNgoIjLh3VhkOd plkrCyJpL/u+GFRQv6Cc6VtODw5SL2lXwWBXuJgGbuon6M351MfObdkxdtY6q64Nqmdb JIxQ== X-Forwarded-Encrypted: i=1; AFNElJ95f3Hy0IX/k8kHkxTSiE0xWzfiaIp+N8eY7J6Wfsl4RZWA9/tGEN2qzEGNJ/fUcbDGIAKcuftJ2CjgcF8=@vger.kernel.org X-Gm-Message-State: AOJu0YwtiTGosywXnS7Rib3REBNNfjwALQD3sRgnTBAe03AIAjPbmylZ 6BTH20i6dLBEWcnGCQfyo74khfw1irLPfz60c9PXljt4UL3nR1H11SPoY3ZXe6/doXRwBsblmDb UAsUNAuFfGYu7hOF+FYkBG7OoactxOLIp07ChpPNQopy2LWV9ZFnwNvGIgnjhxpeuMAHSJwAPc3 4= X-Gm-Gg: AeBDieuSyVWMaRAdcfvatj2nRik4qtikB3v43KUujOFJxrriSsvo4M4EsLKzzMudnE9 X6erJyfu/sZ/LfkIMkxcJp7yTbY1X0QrWRNZKDrzfhSDzzTAK+vO7ySVII/3rmBOsom+BrA53uz sigTtVRmAizlkKsPGrw4lUnoZ0fE6xr8og2vxNUNtsJLU5naBFUzWjgkUiafd5Xs0EfukgoJVXH 8H4K5kSomzR4UHpF68OkTUKoNFMfNFRuogvxSzppGSSULVEX+wLKiX5qU68xYTp4Pkh3UirLhpe OsC5Kt95JhIR9tRq/zWDvw8xgvg3pP9/RKY2delJ2xx3ciDqn1jOfZNaBs42mGfKs9k1jrthgLp hv8ufkTjwcy7mIZWkWJpHNaLN9Tpo9t+VxBX01uUkkVwobreVWUycE5T0GmjRjna+ X-Received: by 2002:a17:902:ebc3:b0:2b2:3eec:c75f with SMTP id d9443c01a7336-2ba798a9396mr43246925ad.28.1778084904324; Wed, 06 May 2026 09:28:24 -0700 (PDT) X-Received: by 2002:a17:902:ebc3:b0:2b2:3eec:c75f with SMTP id d9443c01a7336-2ba798a9396mr43246545ad.28.1778084903722; Wed, 06 May 2026 09:28:23 -0700 (PDT) Received: from [10.206.105.200] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ba7ca106e8sm32048405ad.62.2026.05.06.09.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 09:28:23 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 21:58:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 02/13] dt-bindings: media: qcom,venus: Remove clock, power-domain, and iommus from common schema Content-Language: en-US To: Krzysztof Kozlowski Cc: Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Stefan Schmidt , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stanimir Varbanov , Joerg Roedel , Will Deacon , Robin Murphy , Bjorn Andersson , Konrad Dybcio , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, iommu@lists.linux.dev References: <20260505-glymur-v4-0-17571dbd1caa@oss.qualcomm.com> <20260505-glymur-v4-2-17571dbd1caa@oss.qualcomm.com> <20260506-inquisitive-wondrous-lori-a9e639@quoll> <455376f9-48c2-e663-3be3-fd310afb7f7f@oss.qualcomm.com> <333ba4cd-8168-41f1-afdc-348f99ed0611@kernel.org> From: Vishnu Reddy In-Reply-To: <333ba4cd-8168-41f1-afdc-348f99ed0611@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: zxF5jNAHr1uGtoIsZ0F2gXnQV0eG-agP X-Proofpoint-GUID: zxF5jNAHr1uGtoIsZ0F2gXnQV0eG-agP X-Authority-Analysis: v=2.4 cv=cKXQdFeN c=1 sm=1 tr=0 ts=69fb6c29 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=Ao3bqe3Qqjuf2QKdZGMA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTA2MDE2MCBTYWx0ZWRfX4ysF51jpEjdF +2FZM3Mf7ttoYW+YAptDHnakI+y1DvWcH+U7up0jmlN/IzY5rf+shfKeUVpBDqdxyPMs1+STYdN tD6q4ic9MNDF9f0eQvHnqsEAj4vu/JrK0Vg5a2JRnwDNjrhxPN9lvAkVZ7fO8AglIPJ/pCnKj7V jl8UNw+ILiDIdxMvi0Zn2Xsmi0VaGlhnA9zYcz1xVWdlBQqfuZg8mPxmzKFK85UgGYzVuqc5Grm 2wUy811vxQX/4GbsvHbC8yuzWM2fiqtUKVFZvIsMKW1MdRcZhIaDOD5gGoKcMPzI1R/S2jmGVGQ 70WbdchLfPenX+OzdUBeR48vBtOViAJitQrtVIUM+ogyTaAUdGsm6b70xQB349vNxUxA8aW45pK hqFAzJpvaJKz2oycqZsgk5RfYlXbkNCNfxWPB+nB40Mu18PMFDPsGA/orGAerDy5sbH9Y5H7WO/ QujP8RWII9LbjAkMjdg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-06_01,2026-05-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 malwarescore=0 clxscore=1015 spamscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605060160 On 5/6/2026 6:39 PM, Krzysztof Kozlowski wrote: > On 06/05/2026 11:32, Vishnu Reddy wrote: >> On 5/6/2026 12:11 PM, Krzysztof Kozlowski wrote: >>> On Tue, May 05, 2026 at 12:29:23PM +0530, Vishnu Reddy wrote: >>>> The common schema defines minItems and maxItems for clocks, power-domains, >>>> and iommus. This suggests that the number of these resources can vary, >>>> while in reality they are fixed constraints per platform. >>> OK, that's interesting approach. I am fine with it, but then you need to >>> remove these from "required:" list as well, because requiring properties >>> which are not defined here is not the most readable. >> Ack, I will remove them from "required:" in the next revision. >> >>> I still do not understand though why you cannot just grow the properties >>> here. The point of this schema is to define common set for range of >>> devices, because all of these devices are supposed to be veri similar. >> If a new platform schema uses this common schema but does not explicitly >> re-declare clocks or power-domains, it will inherit minItems and maxItems > But new platform MUST define them, because each platform has both clocks > and power domains. > >> range from the common schema. This gives the false impression that the >> resource count is flexible for that platform, when in reality it should >> be a fixed constraints. >> >> If a new platform requires more resources than the current maxItems (e.g., >> Glymur due to its dual vcodec core design), we need to keep bumping maxItems >> in the common schema every time a new platform exceeds the previous limit. >> That makes the common schema a moving target driven by platform specific. > That's pretty expected, I don't see a problem in that. I am fine with increasing maxItems in the common schema. I can set it to a reasonable value (for example, up to 20) so that it accommodates future platforms without frequent changes. Anyway, each platform schema must define fixed constraints, since clocks and power-domains are mandatory per platform. At the same time, I am also fine with the alternative approach of removing these properties from the common schema entirely, since the fixed constraints are already defined in each platform schema. I'm fine with both approaches. Could you please let me know which one you would prefer going forward? Thanks, Vishnu Reddy > Best regards, > Krzysztof