From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Rob Herring (Arm)" <robh@kernel.org>, Lee Jones <lee@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Pankaj Dubey <pankaj.dubey@samsung.com>,
Heiko Stuebner <heiko@sntech.de>,
Liviu Dudau <liviu.dudau@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Peter Griffin <peter.griffin@linaro.org>,
Will McVicker <willmcvicker@google.com>,
John Madieu <john.madieu.xa@bp.renesas.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 3/3] mfd: syscon: Allow syscon nodes without a "syscon" compatible
Date: Mon, 23 Dec 2024 16:02:05 +0100 [thread overview]
Message-ID: <bb0b12fe-af1f-4ad5-9466-7aaccc3d986e@linaro.org> (raw)
In-Reply-To: <20241217-syscon-fixes-v2-3-4f56d750541d@kernel.org>
On 17/12/2024 19:11, Rob Herring (Arm) wrote:
> of_syscon_register_regmap() was added for nodes which need a custom
> regmap setup. It's not really correct for those nodes to claim they are
> compatible with "syscon" as the default handling likely doesn't work in
> those cases. If device_node_get_regmap() happens to be called first,
> then of_syscon_register() will be called and an incorrect regmap will be
> created (barring some other error). That may lead to unknown results in
> the worst case. In the best case, of_syscon_register_regmap() will fail
> with -EEXIST. This problem remains unless these cases drop "syscon" (an
> ABI issue) or we exclude them using their specific compatible. ATM,
> there is only one user: "google,gs101-pmu"
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-23 15:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-17 18:11 [PATCH v2 0/3] mfd: syscon: Cleanup, fix race condition and remove platform driver Rob Herring (Arm)
2024-12-17 18:11 ` [PATCH v2 1/3] mfd: syscon: Fix race in device_node_get_regmap() Rob Herring (Arm)
2024-12-17 19:35 ` William McVicker
2024-12-23 2:11 ` Pankaj Dubey
2024-12-23 2:14 ` Pankaj Dubey
2024-12-17 18:11 ` [PATCH v2 2/3] mfd: syscon: Remove the platform driver support Rob Herring (Arm)
2024-12-17 19:36 ` William McVicker
2024-12-18 10:10 ` Liviu Dudau
2024-12-23 2:13 ` Pankaj Dubey
2024-12-23 14:59 ` Krzysztof Kozlowski
2024-12-17 18:11 ` [PATCH v2 3/3] mfd: syscon: Allow syscon nodes without a "syscon" compatible Rob Herring (Arm)
2024-12-17 19:37 ` William McVicker
2024-12-23 2:16 ` Pankaj Dubey
2024-12-23 15:02 ` Krzysztof Kozlowski [this message]
2025-01-22 9:43 ` Vaishnav Achath
2025-01-24 20:03 ` Rob Herring
2025-01-09 11:12 ` [PATCH v2 0/3] mfd: syscon: Cleanup, fix race condition and remove platform driver Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb0b12fe-af1f-4ad5-9466-7aaccc3d986e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=arnd@arndb.de \
--cc=heiko@sntech.de \
--cc=john.madieu.xa@bp.renesas.com \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=lpieralisi@kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).