From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4BD0C5DF63 for ; Wed, 6 Nov 2019 16:50:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BFF1C2166E for ; Wed, 6 Nov 2019 16:50:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732328AbfKFQuI (ORCPT ); Wed, 6 Nov 2019 11:50:08 -0500 Received: from mga11.intel.com ([192.55.52.93]:37943 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728832AbfKFQuI (ORCPT ); Wed, 6 Nov 2019 11:50:08 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 08:50:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,275,1569308400"; d="scan'208";a="214301961" Received: from linux.intel.com ([10.54.29.200]) by orsmga002.jf.intel.com with ESMTP; 06 Nov 2019 08:50:07 -0800 Received: from [10.251.82.133] (abudanko-mobl.ccr.corp.intel.com [10.251.82.133]) by linux.intel.com (Postfix) with ESMTP id 0EDA0580A3E; Wed, 6 Nov 2019 08:50:04 -0800 (PST) Subject: Re: [RFC] perf session: Fix compression processing To: Jiri Olsa , Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Ingo Molnar , Alexander Shishkin , Namhyung Kim , Andi Kleen , linux-kernel References: <20191103222441.GE8251@krava> From: Alexey Budankov Organization: Intel Corp. Message-ID: Date: Wed, 6 Nov 2019 19:50:03 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191103222441.GE8251@krava> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04.11.2019 1:24, Jiri Olsa wrote: > hi, > I'm not sure I follow everything on compression, > so I might have missed something, but patch below > fixes the issue for me. > > jirka > > > --- > The compressed data processing occasionally fails with: > $ perf report --stdio -vv > decomp (B): 44519 to 163000 > decomp (B): 48119 to 174800 > decomp (B): 65527 to 131072 > fetch_mmaped_event: head=0x1ffe0 event->header_size=0x28, mmap_size=0x20000: fuzzed perf.data? > Error: > failed to process sample > ... > > It's caused by recent fuzzer fix that does not take into account > that compressed data do not need to by fully present in the buffer, > so it's ok to just return NULL and not to fail. > > Fixes: 57fc032ad643 ("perf session: Avoid infinite loop when seeing invalid header.size") > Link: http://lkml.kernel.org/n/tip-q1biqscs4stcmc9bs1iokfro@git.kernel.org > Signed-off-by: Jiri Olsa > --- > tools/perf/util/session.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) I am on vacations currently, getting back on Monday (11/11). Please expect delay in response. ~Alexey