[PATCH 6/7] soc: aspeed: lpc-snoop: Rearrange channel paths

Andrew Jeffery
2025-04-11T01:09:14Z

Order assignments such that tests for conditions not involving resource
acquisition are ordered before those testing acquired resources, and
order managed resource acquisition before unmanaged where possible. This
way we minimise the amount of manual cleanup required.

In the process, improve readability of the code by introducing a channel
pointer that takes the place of the repeated object lookups.

Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
---
drivers/soc/aspeed/aspeed-lpc-snoop.c | 47 ++++++++++++++++++++---------------
1 file changed, 27 insertions(+), 20 deletions(-)

diff --git a/drivers/soc/aspeed/aspeed-lpc-snoop.c b/drivers/soc/aspeed/aspeed-lpc-snoop.c
index f6952f71eda52c95aea5ad1084edd218b88f1234..0b2044fd79b1be08dfa33bfcaf249b020c909bb9 100644
--- a/drivers/soc/aspeed/aspeed-lpc-snoop.c
+++ b/drivers/soc/aspeed/aspeed-lpc-snoop.c
@@ -189,31 +189,33 @@ static int aspeed_lpc_enable_snoop(struct aspeed_lpc_snoop *lpc_snoop,
{
const struct aspeed_lpc_snoop_model_data *model_data;
u32 hicr5_en, snpwadr_mask, snpwadr_shift, hicrb_en;
+ struct aspeed_lpc_snoop_channel *channel;
int rc = 0;

if (index < 0 || index >= ARRAY_SIZE(lpc_snoop->chan))
return -EINVAL;

- if (lpc_snoop->chan[index].enabled)
+ channel = &lpc_snoop->chan[index];
+
+ if (channel->enabled)
return -EBUSY;

- init_waitqueue_head(&lpc_snoop->chan[index].wq);
- /* Create FIFO datastructure */
- rc = kfifo_alloc(&lpc_snoop->chan[index].fifo,
- SNOOP_FIFO_SIZE, GFP_KERNEL);
+ init_waitqueue_head(&channel->wq);
+
+ channel->miscdev.minor = MISC_DYNAMIC_MINOR;
+ channel->miscdev.fops = &snoop_fops;
+ channel->miscdev.parent = dev;
+
+ channel->miscdev.name =
+ devm_kasprintf(dev, GFP_KERNEL, "%s%d", DEVICE_NAME, index);
+ if (!channel->miscdev.name)
+ return -ENOMEM;
+
+ rc = kfifo_alloc(&channel->fifo, SNOOP_FIFO_SIZE, GFP_KERNEL);
if (rc)
return rc;

- lpc_snoop->chan[index].miscdev.minor = MISC_DYNAMIC_MINOR;
- lpc_snoop->chan[index].miscdev.name =
- devm_kasprintf(dev, GFP_KERNEL, "%s%d", DEVICE_NAME, index);
- if (!lpc_snoop->chan[index].miscdev.name) {
- rc = -ENOMEM;
- goto err_free_fifo;
- }
- lpc_snoop->chan[index].miscdev.fops = &snoop_fops;
- lpc_snoop->chan[index].miscdev.parent = dev;
- rc = misc_register(&lpc_snoop->chan[index].miscdev);
+ rc = misc_register(&channel->miscdev);
if (rc)
goto err_free_fifo;

@@ -236,6 +238,7 @@ static int aspeed_lpc_enable_snoop(struct aspeed_lpc_snoop *lpc_snoop,
goto err_misc_deregister;
}

+ /* Enable LPC snoop channel at requested port */
regmap_update_bits(lpc_snoop->regmap, HICR5, hicr5_en, hicr5_en);
regmap_update_bits(lpc_snoop->regmap, SNPWADR, snpwadr_mask,
lpc_port << snpwadr_shift);
@@ -244,7 +247,7 @@ static int aspeed_lpc_enable_snoop(struct aspeed_lpc_snoop *lpc_snoop,
if (model_data && model_data->has_hicrb_ensnp)
regmap_update_bits(lpc_snoop->regmap, HICRB, hicrb_en, hicrb_en);

- lpc_snoop->chan[index].enabled = true;
+ channel->enabled = true;

return 0;

@@ -259,10 +262,14 @@ __attribute__((nonnull))
static void aspeed_lpc_disable_snoop(struct aspeed_lpc_snoop *lpc_snoop,
int index)
{
+ struct aspeed_lpc_snoop_channel *channel;
+
if (index < 0 || index >= ARRAY_SIZE(lpc_snoop->chan))
return;

- if (!lpc_snoop->chan[index].enabled)
+ channel = &lpc_snoop->chan[index];
+
+ if (!channel->enabled)
return;

/* Disable interrupts along with the device */
@@ -281,10 +288,10 @@ static void aspeed_lpc_disable_snoop(struct aspeed_lpc_snoop *lpc_snoop,
return;
}

- lpc_snoop->chan[index].enabled = false;
+ channel->enabled = false;
/* Consider improving safety wrt concurrent reader(s) */
- misc_deregister(&lpc_snoop->chan[index].miscdev);
- kfifo_free(&lpc_snoop->chan[index].fifo);
+ misc_deregister(&channel->miscdev);
+ kfifo_free(&channel->fifo);
}

static int aspeed_lpc_snoop_probe(struct platform_device *pdev)

--
2.39.5