Re: [PATCH 6/7] soc: aspeed: lpc-snoop: Rearrange channel paths

Jean Delvare
2025-04-17T09:52:39Z

On Fri, 11 Apr 2025 10:38:36 +0930, Andrew Jeffery wrote:
> Order assignments such that tests for conditions not involving resource
> acquisition are ordered before those testing acquired resources, and
> order managed resource acquisition before unmanaged where possible. This
> way we minimise the amount of manual cleanup required.
>
> In the process, improve readability of the code by introducing a channel
> pointer that takes the place of the repeated object lookups.
>
> Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
> ---
> drivers/soc/aspeed/aspeed-lpc-snoop.c | 47 ++++++++++++++++++++---------------
> 1 file changed, 27 insertions(+), 20 deletions(-)
> (...)

LGTM.

Acked-by: Jean Delvare <jdelvare@suse.de>

--
Jean Delvare
SUSE L3 Support