From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753423AbcKNKRi (ORCPT ); Mon, 14 Nov 2016 05:17:38 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:34253 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933077AbcKNKRg (ORCPT ); Mon, 14 Nov 2016 05:17:36 -0500 Subject: Re: [PATCH 1/3] crash: move crashkernel parsing and vmcore related code under CONFIG_CRASH_CORE To: Baoquan He References: <147877899077.31483.3740501843050856595.stgit@hbathini.in.ibm.com> <147877904646.31483.2251653505359017982.stgit@hbathini.in.ibm.com> <20161114053627.GC19995@x1> Cc: fenghua.yu@intel.com, tony.luck@intel.com, linux-ia64@vger.kernel.org, dyoung@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, ebiederm@xmission.com, linuxppc-dev@lists.ozlabs.org, vgoyal@redhat.com From: Hari Bathini Date: Mon, 14 Nov 2016 15:47:14 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161114053627.GC19995@x1> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16111410-0016-0000-0000-00000373772E X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16111410-0017-0000-0000-0000276711B6 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-11-14_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611140212 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 14 November 2016 11:06 AM, Baoquan He wrote: > On 11/10/16 at 05:27pm, Hari Bathini wrote: >> Traditionally, kdump is used to save vmcore in case of a crash. Some >> architectures like powerpc can save vmcore using architecture specific >> support instead of kexec/kdump mechanism. Such architecture specific >> support also needs to reserve memory, to be used by dump capture kernel. >> crashkernel parameter can be a reused, for memory reservation, by such >> architecture specific infrastructure. >> >> But currently, code related to vmcoreinfo and parsing of crashkernel >> parameter is built under CONFIG_KEXEC_CORE. This patch introduces >> CONFIG_CRASH_CORE and moves the above mentioned code under this config, >> allowing code reuse without dependency on CONFIG_KEXEC. While here, >> removing the multiple definitions of append_elf_note() and final_note() >> for one defined under CONFIG_CONFIG_CORE. There is no functional change >> with this patch. > Can't think of a reason to object. > > Could it be that do the moving from kexec_core.c to crash_core.c only, > then do the arch specific clean up in another patch? Right. Will move arch specific code into a separate patch, on the next version.. > Besides there's already a file crash_dump.h, can we reuse that? Did think about it. But as it is meant for dump capture kernel (CONFIG_CRASH_DUMP) and CONFIG_KEXEC_CORE being independent, didn't pursue it.. Thanks Hari