From: Lukasz Luba <lukasz.luba@arm.com>
To: Atul Kumar Pant <atulpant.linux@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
rafael@kernel.org, len.brown@intel.com, pavel@kernel.org
Subject: Re: [PATCH] Documentation: EM: Fix typos in example driver code
Date: Thu, 22 May 2025 09:01:24 +0100 [thread overview]
Message-ID: <bb462e70-bd55-44eb-9701-06905cf64986@arm.com> (raw)
In-Reply-To: <20250511071141.13237-1-atulpant.linux@gmail.com>
On 5/11/25 08:11, Atul Kumar Pant wrote:
> Fix the API name to free the allocated table in the example driver code
> that modifies the EM. Also fix the passing of correct table when
> updating the cost.
>
> Signed-off-by: Atul Kumar Pant <atulpant.linux@gmail.com>
> ---
> Documentation/power/energy-model.rst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/power/energy-model.rst b/Documentation/power/energy-model.rst
> index ada4938c3..29388f6d1 100644
> --- a/Documentation/power/energy-model.rst
> +++ b/Documentation/power/energy-model.rst
> @@ -381,17 +381,17 @@ up periodically to check the temperature and modify the EM data::
> 26 rcu_read_unlock();
> 27
> 28 /* Calculate 'cost' values for EAS */
> - 29 ret = em_dev_compute_costs(dev, table, pd->nr_perf_states);
> + 29 ret = em_dev_compute_costs(dev, new_table, pd->nr_perf_states);
> 30 if (ret) {
> 31 dev_warn(dev, "EM: compute costs failed %d\n", ret);
> - 32 em_free_table(em_table);
> + 32 em_table_free(em_table);
> 33 return;
> 34 }
> 35
> 36 ret = em_dev_update_perf_domain(dev, em_table);
> 37 if (ret) {
> 38 dev_warn(dev, "EM: update failed %d\n", ret);
> - 39 em_free_table(em_table);
> + 39 em_table_free(em_table);
> 40 return;
> 41 }
> 42
Thanks for having a look at this, LGTM.
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
prev parent reply other threads:[~2025-05-22 8:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-11 7:11 [PATCH] Documentation: EM: Fix typos in example driver code Atul Kumar Pant
2025-05-22 8:01 ` Lukasz Luba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb462e70-bd55-44eb-9701-06905cf64986@arm.com \
--to=lukasz.luba@arm.com \
--cc=atulpant.linux@gmail.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox