From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: Kalle Valo <kvalo@codeaurora.org>,
Mikhail Rudenko <mike.rudenko@gmail.com>
Cc: Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-hsien Lin <chi-hsien.lin@infineon.com>,
Wright Feng <wright.feng@infineon.com>,
Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Dmitry Osipenko <digetx@gmail.com>,
Double Lo <double.lo@cypress.com>,
Remi Depommier <rde@setrix.com>, Amar Shankar <amsr@cypress.com>,
Saravanan Shanmugham <saravanan.shanmugham@cypress.com>,
Frank Kao <frank.kao@cypress.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
SHA-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] brcmfmac: use separate firmware for 43430 revision 2
Date: Mon, 28 Jun 2021 12:11:57 +0200 [thread overview]
Message-ID: <bb4eece6-e164-7dc2-bd9a-33fe0714d7a7@broadcom.com> (raw)
In-Reply-To: <87o8bvgqt8.fsf@tynnyri.adurom.net>
On 6/24/2021 6:39 PM, Kalle Valo wrote:
> Mikhail Rudenko <mike.rudenko@gmail.com> writes:
>
>> On 2021-05-10 at 11:06 MSK, Arend van Spriel <arend.vanspriel@broadcom.com> wrote:
>>> On 5/10/2021 1:30 AM, Mikhail Rudenko wrote:
>>>> A separate firmware is needed for Broadcom 43430 revision 2. This
>>>> chip can be found in e.g. certain revisions of Ampak AP6212 wireless
>>>> IC. Original firmware file from IC vendor is named
>>>> 'fw_bcm43436b0.bin', but brcmfmac and also btbcm drivers report chip
>>>
>>> That is bad naming. There already is a 43436 USB device.
>>>
>>>> id 43430, so requested firmware file name is
>>>> 'brcmfmac43430b0-sdio.bin' in line with other 43430 revisions.
>>>
>>> As always there is the question about who will be publishing this
>>> particular firmware file to linux-firmware.
>>
>> The above mentioned file can be easily found by web search. Also, the
>> corresponding patch for the bluetooth part has just been accepted
>> [1]. Is it strictly necessary to have firmware file in linux-firmware in
>> order to have this patch accepted?
>
> This patch is a bit in the gray area. We have a rule that firmware
> images should be in linux-firmware, but as the vendor won't submit one
> and I assume the license doesn't approve the community submit it either,
> there is not really any solution for the firmware problem.
At the moment I am not sure which company/division is shipping the 43430
rev 2 or 43436. Having it in linux-firmware is still preferred.
> On the other hand some community members have access to the firmware
> somehow so this patch is useful to the community, and I think taking an
> exception to the rule in this case is justified. So I am inclined
> towards applying the patch.
As an end-user community members using the device are allowed to use the
firmware to run on that device. So I tend to agree with you.
> Thoughts? I also have another similar patch in the queue:
>
> https://patchwork.kernel.org/project/linux-wireless/patch/20210307113550.7720-1-konrad.dybcio@somainline.org/
I will review both and comment/ack them.
Regards,
Arend
next prev parent reply other threads:[~2021-06-28 10:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-09 23:30 [PATCH] brcmfmac: use separate firmware for 43430 revision 2 Mikhail Rudenko
2021-05-10 8:06 ` Arend van Spriel
2021-05-14 9:41 ` Mikhail Rudenko
2021-05-21 13:22 ` Mikhail Rudenko
2021-06-24 16:39 ` Kalle Valo
2021-06-28 10:11 ` Arend van Spriel [this message]
2021-06-28 12:16 ` Arend van Spriel
2021-06-28 14:05 ` Mikhail Rudenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb4eece6-e164-7dc2-bd9a-33fe0714d7a7@broadcom.com \
--to=arend.vanspriel@broadcom.com \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=amsr@cypress.com \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=davem@davemloft.net \
--cc=digetx@gmail.com \
--cc=double.lo@cypress.com \
--cc=frank.kao@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mike.rudenko@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rde@setrix.com \
--cc=saravanan.shanmugham@cypress.com \
--cc=wright.feng@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox