From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66F1B37418D; Mon, 19 Jan 2026 14:21:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768832465; cv=none; b=mWK5wkzP2onZAn0/pTZGd/W1eiKCbio/+DvATUZ8CZ+YJvQD2omewxOQk/0uJSEhMRzRm4shtLXr39VWEjJmdHQTIeyiceJ+RLOSLxfPQAjc0AQOQIN8tFwgNXJwyDpyzSnXryRRaYQD+LiD7IkdTQKJxdHznTI3j3K6ygLImxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768832465; c=relaxed/simple; bh=RjyUtJwmG1G4kZbuXRuMcwRIAzdLOCcrAwI3cXKpba8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pSlL838CcymlzERMls7BqZR1ruuZCUFQ/K/NKLo/4amo21fXsdz/FU6CcMCSsuBmsyengj4xgzo73Y61dJDl8xJSkyGc1psCOepr+6jc0m2NGCKrmKrc7/Rx9euNHPHcO49pq5rDSnpvrXRgg/qbbRAwz7KtbSozn4b+gs4zTvA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=CA3py8ft; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="CA3py8ft" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=c7Ep0GD4eG911kODoOvUPprYM2xLb7geaPpEU8Rcz+g=; b=CA3py8ftIBYki7YqehhBkcUCAE Jq7C+1KCwjIrVDFC+GK3VKxuTunuovVb/OOJLH4mvTDrjY9ZYAsq64o/VUCK+zUCJVX18CKCiZgwJ nlEuzXZNNYKP51fFNdGzccFRUqUQ3D7Cv9ycIXAkCOtHHRr9Ap3iqOw2o8Cp1r46+4wU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vhq7T-003VPQ-Ln; Mon, 19 Jan 2026 15:20:39 +0100 Date: Mon, 19 Jan 2026 15:20:39 +0100 From: Andrew Lunn To: Billy Tsai Cc: Linus Walleij , Bartosz Golaszewski , Joel Stanley , Andrew Jeffery , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Andrew Jeffery , "devicetree@vger.kernel.org" , BMC-SW Subject: Re: [PATCH 3/5] gpio: aspeed-sgpio: Create llops to handle hardware access Message-ID: References: <20260117-upstream_sgpio-v1-0-850ef3ffb680@aspeedtech.com> <20260117-upstream_sgpio-v1-3-850ef3ffb680@aspeedtech.com> <55fbb766-12b5-441a-b06c-d807097e5476@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > We did consider regmap. However, llops is intended to abstract not only > register > > access but also layout-specific bit mapping, which is difficult to express > > cleanly with a flat regmap interface. O.K. I was just thinking, if you can swap to regmap, you could maybe then go one step further and use gpio_regmap_register(). But if you have extra logic in here, that will not work. Andrew