From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA8BC433DB for ; Thu, 21 Jan 2021 17:36:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 508EE21973 for ; Thu, 21 Jan 2021 17:36:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733190AbhAURgH convert rfc822-to-8bit (ORCPT ); Thu, 21 Jan 2021 12:36:07 -0500 Received: from mga14.intel.com ([192.55.52.115]:58758 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388908AbhAURd4 (ORCPT ); Thu, 21 Jan 2021 12:33:56 -0500 IronPort-SDR: rvSDyM0XSrtZMkpu9kEW5l8DtVaD+QLNmvtQhZlgMa5REoQS5HHHlOrDPw3tqawjJ3T2NuAKYD S2tBlrd4+7yw== X-IronPort-AV: E=McAfee;i="6000,8403,9871"; a="178530166" X-IronPort-AV: E=Sophos;i="5.79,364,1602572400"; d="scan'208";a="178530166" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2021 09:33:16 -0800 IronPort-SDR: GShjbow07A9DaZj6VOIn/ssj+PdgcHN9oL4rgXfIHJGW7JTfLAUqiLbxFc1cuDUH3JokcsCYZV ypdUVDnZgNbQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,364,1602572400"; d="scan'208";a="354846464" Received: from irsmsx601.ger.corp.intel.com ([163.33.146.7]) by orsmga006.jf.intel.com with ESMTP; 21 Jan 2021 09:33:12 -0800 Received: from irsmsx601.ger.corp.intel.com (163.33.146.7) by irsmsx601.ger.corp.intel.com (163.33.146.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 21 Jan 2021 17:33:11 +0000 Received: from irsmsx601.ger.corp.intel.com ([163.33.146.7]) by irsmsx601.ger.corp.intel.com ([163.33.146.7]) with mapi id 15.01.1713.004; Thu, 21 Jan 2021 17:33:11 +0000 From: "Rojewski, Cezary" To: Ricardo Ribalda CC: Pierre-Louis Bossart , Liam Girdwood , Jie Yang , "Mark Brown" , Jaroslav Kysela , Takashi Iwai , Mateusz Gorski , "Andy Shevchenko" , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , Lukasz Majczak Subject: RE: [PATCH v2 1/2] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib skl_tplg_complete Thread-Topic: [PATCH v2 1/2] ASoC: Intel: Skylake: skl-topology: Fix OOPs ib skl_tplg_complete Thread-Index: AQHW8Bk4t64Bz53R0UWGbQi6OPDjnqoyVk5Q Date: Thu, 21 Jan 2021 17:33:11 +0000 Message-ID: References: <20210121171644.131059-1-ribalda@chromium.org> In-Reply-To: <20210121171644.131059-1-ribalda@chromium.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 x-originating-ip: [163.33.253.164] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-21 6:16 PM, Ricardo Ribalda wrote: > If dobj->control is not initialized we end up in an OOPs during > skl_tplg_complete: > > [ 26.553358] BUG: kernel NULL pointer dereference, address: > 0000000000000078 > [ 26.561151] #PF: supervisor read access in kernel mode > [ 26.566897] #PF: error_code(0x0000) - not-present page > [ 26.572642] PGD 0 P4D 0 > [ 26.575479] Oops: 0000 [#1] PREEMPT SMP PTI > [ 26.580158] CPU: 2 PID: 2082 Comm: udevd Tainted: G C > 5.4.81 #4 > [ 26.588232] Hardware name: HP Soraka/Soraka, BIOS > Google_Soraka.10431.106.0 12/03/2019 > [ 26.597082] RIP: 0010:skl_tplg_complete+0x70/0x144 [snd_soc_skl] > > Fixes: 2d744ecf2b98 ("ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHL") > Signed-off-by: Ricardo Ribalda Thanks for the fix, Ricardo. Reviewed-by: Cezary Rojewski