From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A984C6FD20 for ; Tue, 21 Mar 2023 23:54:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbjCUXyI (ORCPT ); Tue, 21 Mar 2023 19:54:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229713AbjCUXyD (ORCPT ); Tue, 21 Mar 2023 19:54:03 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DE0D24BE7; Tue, 21 Mar 2023 16:53:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 8547DCE1B99; Tue, 21 Mar 2023 23:53:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4A5DC433D2; Tue, 21 Mar 2023 23:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679442827; bh=Se62AcjZEbRL9aU/OO95SPGgaa/PfL/hcFXxxs6W4G0=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=FI/d6pDxJ6Idr3dco1XDBXPi+ZyFLwVSffYeTmO4Sz2ph24n2fKyyK+mIswHebjd7 qlXoewwBY+hl9zSL6FaBZj/7SN6WIZr8EsVG4CWlNa2grbCLjekWETUfvsLgKSPxUP uJN895g8tIv7+QzFBzXW2xODVquAYWMh9Bdvko40hSqQPi1B3ygQvSWorYnFy6sBYp b2dRSBAdNbT7a+hwfXUcCZvA9TwHL4wNUARwsunBN6cEXX4WOXSB3Yk1VeprVbMsyY Jc5GCEIgTL2i8WeF6KnsV5LyqYOOZz805tq/3jxrpYmCm9e3CqG5dS4JuVXDLEJMNu mAcnDLj0svyyA== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221209152913.1335068-6-marpagan@redhat.com> References: <20221209152913.1335068-1-marpagan@redhat.com> <20221209152913.1335068-6-marpagan@redhat.com> Subject: Re: [PATCH 5/6] clk: socfpga: use of_clk_add_hw_provider and improve error handling From: Stephen Boyd Cc: Marco Pagani , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Dinh Nguyen , Marco Pagani , Michael Turquette Date: Tue, 21 Mar 2023 16:53:44 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Marco Pagani (2022-12-09 07:29:12) > The function of_clk_add_provider() has been deprecated, so use its > suggested replacement of_clk_add_hw_provider() instead. >=20 > Since of_clk_add_hw_provider() can fail, like of_clk_add_provider(), > check its return value and do the error handling. >=20 > The return type of the init function has been changed to void since > the return value was not used, and the indentation of the parameters has > been aligned to match open parenthesis, as suggested by checkpatch. >=20 > The err variable has been renamed rc for consistency. >=20 > Signed-off-by: Marco Pagani > --- Applied to clk-next