From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org,
David Ahern <dsa@cumulusnetworks.com>,
Doug Ledford <dledford@redhat.com>,
Erez Shitrit <erezsh@mellanox.com>,
Feras Daoud <ferasda@mellanox.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Leon Romanovsky <leon@kernel.org>,
Mark Bloch <markb@mellanox.com>,
Or Gerlitz <ogerlitz@mellanox.com>,
Paolo Abeni <pabeni@redhat.com>, Roi Dayan <roid@mellanox.com>,
Sagi Grimberg <sagi@grimberg.me>,
Sean Hefty <sean.hefty@intel.com>,
Yuval Shaia <yuval.shaia@oracle.com>,
Zhu Yanjun <yanjun.zhu@oracle.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 2/9] IB/IPoIB: Delete an error message for a failed memory allocation
Date: Fri, 7 Apr 2017 23:00:05 +0200 [thread overview]
Message-ID: <bb64e4e8-1ebd-c4dd-1da4-1041eb2bc63d@users.sourceforge.net> (raw)
In-Reply-To: <ce4249f2-c7e7-0282-2cff-3f9c3991efa3@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Fri, 7 Apr 2017 19:23:55 +0200
The script "checkpatch.pl" pointed information out like the following.
WARNING: Possible unnecessary 'out of memory' message
Thus remove such a statement here.
Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/infiniband/ulp/ipoib/ipoib_main.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index 3d3e49fb15b7..c5024c6d38e7 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -1634,11 +1634,8 @@ int ipoib_dev_init(struct net_device *dev, struct ib_device *ca, int port)
goto out;
priv->tx_ring = vzalloc(ipoib_sendq_size * sizeof *priv->tx_ring);
- if (!priv->tx_ring) {
- printk(KERN_WARNING "%s: failed to allocate TX ring (%d entries)\n",
- ca->name, ipoib_sendq_size);
+ if (!priv->tx_ring)
goto out_rx_ring_cleanup;
- }
/* priv->tx_head, tx_tail & tx_outstanding are already 0 */
--
2.12.2
next prev parent reply other threads:[~2017-04-07 21:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-07 20:54 [PATCH 0/9] InfiniBand-ULP: Fine-tuning for several function implementations SF Markus Elfring
2017-04-07 20:57 ` [PATCH 1/9] IB/IPoIB: Use kcalloc() in two functions SF Markus Elfring
2017-04-09 12:26 ` Sagi Grimberg
2017-04-07 21:00 ` SF Markus Elfring [this message]
2017-04-09 12:26 ` [PATCH 2/9] IB/IPoIB: Delete an error message for a failed memory allocation Sagi Grimberg
2017-04-07 21:01 ` [PATCH 3/9] IB/IPoIB: Enclose six expressions for the sizeof operator by parentheses SF Markus Elfring
2017-04-09 12:26 ` Sagi Grimberg
2017-04-07 21:03 ` [PATCH 4/9] IB/IPoIB: Delete unwanted spaces behind usages of the sizeof operator SF Markus Elfring
2017-04-09 12:26 ` Sagi Grimberg
2017-04-07 21:05 ` [PATCH 5/9] IB/IPoIB: Combine substrings for three messages SF Markus Elfring
2017-04-18 11:33 ` Yuval Shaia
2017-04-07 21:06 ` [PATCH 6/9] IB/iser: Use kmalloc_array() in iser_alloc_rx_descriptors() SF Markus Elfring
2017-04-09 9:01 ` Sagi Grimberg
2017-04-07 21:07 ` [PATCH 7/9] IB/iser: Add spaces for better code readability SF Markus Elfring
2017-04-09 9:02 ` Sagi Grimberg
2017-04-07 21:08 ` [PATCH 8/9] IB/isert: Use kcalloc() in isert_alloc_rx_descriptors() SF Markus Elfring
2017-04-09 9:02 ` Sagi Grimberg
2017-04-07 21:09 ` [PATCH 9/9] IB/isert: Improve size determinations in three functions SF Markus Elfring
2017-04-09 9:02 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb64e4e8-1ebd-c4dd-1da4-1041eb2bc63d@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=dledford@redhat.com \
--cc=dsa@cumulusnetworks.com \
--cc=erezsh@mellanox.com \
--cc=ferasda@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=markb@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=pabeni@redhat.com \
--cc=roid@mellanox.com \
--cc=sagi@grimberg.me \
--cc=sean.hefty@intel.com \
--cc=target-devel@vger.kernel.org \
--cc=yanjun.zhu@oracle.com \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).