From: Dave Hansen <dave.hansen@intel.com>
To: Xie Yuanbin <qq570070308@gmail.com>,
peterz@infradead.org, tglx@kernel.org, riel@surriel.com,
segher@kernel.crashing.org, david@kernel.org, hpa@zytor.com,
arnd@arndb.de, anna-maria@linutronix.de, mingo@redhat.com,
juri.lelli@redhat.com, vincent.guittot@linaro.org,
dietmar.eggemann@arm.com, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, vschneid@redhat.com,
bp@alien8.de, dave.hansen@linux.intel.com, luto@kernel.org,
houwenlong.hwl@antgroup.com, frederic@kernel.org,
akpm@linux-foundation.org, lorenzo.stoakes@oracle.com,
bhe@redhat.com, ryan.roberts@arm.com, urezki@gmail.com,
nysal@linux.ibm.com, max.kellermann@ionos.com
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v6 RESEND 1/3] x86/mm/tlb: Make enter_lazy_tlb() always inline on x86
Date: Tue, 10 Feb 2026 08:07:38 -0800 [thread overview]
Message-ID: <bb662280-1223-44e0-8be1-d0f0cf453e9e@intel.com> (raw)
In-Reply-To: <20260210153202.524-1-qq570070308@gmail.com>
On 2/10/26 07:32, Xie Yuanbin wrote:
> This was just to fix a compilation error:
> 'cpu_tlbstate' is defined in 'include/asm/tlbflush.h' inside of
> '#ifndef MODULE'. So if the '#ifndef MODULE' is not added here,
> the compilation error will be triggered:
Rather than sprinkling #ifdefs and 'cpu_tlbstate' references around,
could we try to keep them confined to asm/tlbflush.h as much as
possible, please?
I mean, mmu_context.h _does_ include asm/tlbflush.h, so even if you
stuck enter_lazy_tlb() in asm/tlbflush.h, everything should keep
working, no?
That would both prevent adding a random #ifdef and keep 'cpu_tlbstate'
references limited.
next prev parent reply other threads:[~2026-02-10 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-09 16:23 [PATCH v6 RESEND 1/3] x86/mm/tlb: Make enter_lazy_tlb() always inline on x86 Xie Yuanbin
2026-02-09 16:23 ` [PATCH v6 RESEND 2/3] sched: Make raw_spin_rq_unlock() inline Xie Yuanbin
2026-02-09 16:23 ` [PATCH v6 RESEND 3/3] sched/core: Make finish_task_switch() and its subfunctions always inline Xie Yuanbin
2026-02-09 19:24 ` [PATCH v6 RESEND 1/3] x86/mm/tlb: Make enter_lazy_tlb() always inline on x86 Dave Hansen
2026-02-10 15:32 ` Xie Yuanbin
2026-02-10 16:07 ` Dave Hansen [this message]
2026-02-11 15:36 ` Xie Yuanbin
2026-02-11 18:01 ` Dave Hansen
2026-02-12 15:19 ` Xie Yuanbin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb662280-1223-44e0-8be1-d0f0cf453e9e@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=bsegall@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=frederic@kernel.org \
--cc=houwenlong.hwl@antgroup.com \
--cc=hpa@zytor.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=luto@kernel.org \
--cc=max.kellermann@ionos.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=nysal@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=qq570070308@gmail.com \
--cc=riel@surriel.com \
--cc=rostedt@goodmis.org \
--cc=ryan.roberts@arm.com \
--cc=segher@kernel.crashing.org \
--cc=tglx@kernel.org \
--cc=urezki@gmail.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox