From: Markus Elfring <Markus.Elfring@web.de>
To: Dejin Zheng <zhengdejin5@gmail.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v1] fbdev: sm712fb: fix an issue about iounmap for a wrong address
Date: Thu, 23 Apr 2020 14:14:48 +0200 [thread overview]
Message-ID: <bb6ba7c9-ad92-9c54-e1c4-91d2f7d0f5f8@web.de> (raw)
> the sfb->fb->screen_base is not save the value get by iounmap() when
> the chip id is 0x720.
I suggest to improve this change description.
How did you determine relevant differences for the mentioned chip model?
> so iounmap() for address sfb->fb->screen_base is not right.
Will another imperative wording become helpful here?
…
> +++ b/drivers/video/fbdev/sm712fb.c
> @@ -1429,6 +1429,8 @@ static int smtc_map_smem(struct smtcfb_info *sfb,
> static void smtc_unmap_smem(struct smtcfb_info *sfb)
> {
> if (sfb && sfb->fb->screen_base) {
> + if (sfb->chip_id == 0x720)
> + sfb->fb->screen_base -= 0x00200000;
> iounmap(sfb->fb->screen_base);
How do you think about to use descriptive identifiers for
the shown constants?
Would you like to clarify any related software analysis approaches?
Regards,
Markus
next reply other threads:[~2020-04-23 12:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 12:14 Markus Elfring [this message]
2020-04-23 14:52 ` [PATCH v1] fbdev: sm712fb: fix an issue about iounmap for a wrong address Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb6ba7c9-ad92-9c54-e1c4-91d2f7d0f5f8@web.de \
--to=markus.elfring@web.de \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox