From: Harry Wentland <harry.wentland@amd.com>
To: "Haowen Bai" <baihaowen@meizu.com>, "Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/amd/display: Fix indenting mistakes in dcn10_hw_sequencer.c
Date: Thu, 7 Apr 2022 10:18:14 -0400 [thread overview]
Message-ID: <bb7635cf-461e-7abd-6092-4be67099c846@amd.com> (raw)
In-Reply-To: <1649311250-17077-1-git-send-email-baihaowen@meizu.com>
On 2022-04-07 02:00, Haowen Bai wrote:
> Smatch reports the following:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn10/dcn10_hw_sequencer.c:2174
> dcn10_enable_vblanks_synchronization() warn: if statement not indented
>
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Harry
> ---
> drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> index ee22f4422d26..3c338b85040c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
> @@ -2172,13 +2172,13 @@ void dcn10_enable_vblanks_synchronization(
> if (master >= 0) {
> for (i = 0; i < group_size; i++) {
> if (i != master && !grouped_pipes[i]->stream->has_non_synchronizable_pclk)
> - grouped_pipes[i]->stream_res.tg->funcs->align_vblanks(
> - grouped_pipes[master]->stream_res.tg,
> - grouped_pipes[i]->stream_res.tg,
> - grouped_pipes[master]->stream->timing.pix_clk_100hz,
> - grouped_pipes[i]->stream->timing.pix_clk_100hz,
> - get_clock_divider(grouped_pipes[master], false),
> - get_clock_divider(grouped_pipes[i], false));
> + grouped_pipes[i]->stream_res.tg->funcs->align_vblanks(
> + grouped_pipes[master]->stream_res.tg,
> + grouped_pipes[i]->stream_res.tg,
> + grouped_pipes[master]->stream->timing.pix_clk_100hz,
> + grouped_pipes[i]->stream->timing.pix_clk_100hz,
> + get_clock_divider(grouped_pipes[master], false),
> + get_clock_divider(grouped_pipes[i], false));
> grouped_pipes[i]->stream->vblank_synchronized = true;
> }
> grouped_pipes[master]->stream->vblank_synchronized = true;
next prev parent reply other threads:[~2022-04-07 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 6:00 [PATCH] drm/amd/display: Fix indenting mistakes in dcn10_hw_sequencer.c Haowen Bai
2022-04-07 14:18 ` Harry Wentland [this message]
2022-04-07 15:52 ` Alex Deucher
2022-04-07 16:07 ` Alex Deucher
2022-04-07 17:32 ` Harry Wentland
2022-04-07 17:37 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb7635cf-461e-7abd-6092-4be67099c846@amd.com \
--to=harry.wentland@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=baihaowen@meizu.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox