Re: [PATCH v3 1/3] dt-bindings: phy: qcom,snps-eusb2-repeater: Add squelch param update

Krzysztof Kozlowski
2025-12-23T14:16:49Z

On 23/12/2025 15:11, Vinod Koul wrote:
> On 19-12-25, 23:01, Krishna Kurapati wrote:
>> Add squelch detect parameter update for synopsys eusb2 repeater. The
>> values (indicated in basis-points) depict a percentage change with
>> respect to the nominal value.
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>> .../devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
>> index 5bf0d6c9c025..f2afcf0e986a 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
>> +++ b/Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml
>> @@ -59,6 +59,14 @@ properties:
>> minimum: 0
>> maximum: 7
>>
>> + qcom,squelch-detector-bp:
>> + description:
>> + This adjusts the voltage level for the threshold used to detect valid
>> + high-speed data.
>> + minimum: -6000
>
> 6000Volts, mV, can you please document the units?

Code is correct, the '-bp' is the unit here. Unless the suffix was
chosen incorrectly?

Best regards,
Krzysztof