Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: Add firmware bindings for Q6V5 MSS

Sibi Sankar
2018-12-28T04:47:32Z

Hi Rob,
Thanks for the review :)

On 2018-12-21 01:40, Rob Herring wrote:
> On Wed, Dec 12, 2018 at 06:14:55PM +0530, Sibi Sankar wrote:
>> Add optional firmware bindings for Q6V5 MSS. It lists the two relative
>> firmware paths which are used for booting and authenticating the
>> Hexagon
>> core.
>>
>> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt | 7
>> +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> index 9ff5b0309417..1f6988a60636 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt
>> @@ -36,6 +36,13 @@ on the Qualcomm Hexagon core.
>> Value type: <stringlist>
>> Definition: must be "wdog", "fatal", "ready", "handover", "stop-ack"
>>
>> +- qcom,firmware:
>
> We already have a standard name 'firmware-name'. Use that. I'm fine
> with
> allowing it to be more than 1 string.

sure will replace "qcom,firmware" with "firmware-name" in the next
re-spin

>
>> + Usage: optional
>> + Value type: <stringlist>
>> + Definition: must list the 2 relative firmware paths (mba and modem
>> + metadata respectively) which are used for booting and
>> + authenticating the Hexagon core.
>> +
>> - clocks:
>> Usage: required
>> Value type: <phandle>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>

--
-- Sibi Sankar --
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.