public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Jiasheng Jiang <jiashengjiangcool@gmail.com>,
	skashyap@marvell.com, jhasan@marvell.com,
	GR-QLogic-Storage-Upstream@marvell.com,
	James.Bottomley@HansenPartnership.com,
	martin.petersen@oracle.com, manish.rangankar@cavium.com,
	nilesh.javali@cavium.com, arun.easi@cavium.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qedf: Use kzalloc() and add check for bdt_info
Date: Fri, 31 Jan 2025 12:32:23 -0800	[thread overview]
Message-ID: <bbb46821-25dc-4f5d-a6bf-cbef34024afd@acm.org> (raw)
In-Reply-To: <20250131195438.44964-1-jiashengjiangcool@gmail.com>

On 1/31/25 11:54 AM, Jiasheng Jiang wrote:
> -	cmgr->io_bdt_pool = kmalloc_array(num_ios, sizeof(struct io_bdt *),
> -	    GFP_KERNEL);
> +	cmgr->io_bdt_pool = kzalloc(num_ios * sizeof(struct io_bdt *), GFP_KERNEL);

Please do not reintroduce the possibility of multiplication overflow. 
What is wrong with adding __GFP_ZERO to the second kmalloc_array()
argument or with using kcalloc()? From include/linux/slab.h:

#define kcalloc(n, size, flags) kmalloc_array(n, size, (flags) | __GFP_ZERO)

Thanks,

Bart.

  reply	other threads:[~2025-01-31 20:32 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-31 19:54 [PATCH] scsi: qedf: Use kzalloc() and add check for bdt_info Jiasheng Jiang
2025-01-31 20:32 ` Bart Van Assche [this message]
2025-01-31 21:35   ` [PATCH v2] scsi: qedf: Use kcalloc() " Jiasheng Jiang
2025-02-02 15:22     ` Markus Elfring
2025-02-02 16:54     ` Markus Elfring
2025-02-02 21:21       ` [PATCH] Replace kmalloc_array() with kcalloc() Jiasheng Jiang
2025-02-02 21:29       ` [PATCH] scsi: qedf: Add check for bdt_info Jiasheng Jiang
2025-02-02 21:32       ` [PATCH] scsi: qedf: Replace kmalloc_array() with kcalloc() Jiasheng Jiang
2025-02-03  7:20         ` [PATCH v3?] " Markus Elfring
2025-02-04  2:51           ` [PATCH v3] " Jiasheng Jiang
2025-02-04  2:52           ` [PATCH v3?] " Jiasheng Jiang
2025-02-04  8:05             ` [v3?] " Markus Elfring
2025-02-05  1:07               ` [PATCH v3 1/2] " Jiasheng Jiang
2025-02-05  1:07                 ` [PATCH v3 2/2] scsi: qedf: Add check for bdt_info Jiasheng Jiang
2025-02-05  1:08               ` [v3?] scsi: qedf: Replace kmalloc_array() with kcalloc() Jiasheng Jiang
2025-02-05  8:11                 ` Markus Elfring
2025-02-06  5:12                   ` Jiasheng Jiang
2025-02-06 12:16                     ` Markus Elfring
2025-02-06  5:25                   ` [PATCH 0/2] scsi: qedf: Replace alloction API and add null check Jiasheng Jiang
2025-02-06  5:25                     ` [PATCH 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc() Jiasheng Jiang
2025-02-06  5:36                       ` Greg KH
2025-02-06  5:38                         ` Greg KH
2025-02-06 19:19                           ` [PATCH v2 " Jiasheng Jiang
2025-02-06 19:20                             ` [PATCH v2 2/2] scsi: qedf: Add check for bdt_info Jiasheng Jiang
2025-02-07 15:09                             ` [PATCH v2 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc() Greg KH
2025-02-07 15:45                               ` [PATCH v3 " Jiasheng Jiang
2025-02-07 15:45                                 ` [PATCH v3 2/2] scsi: qedf: Add check for bdt_info Jiasheng Jiang
2025-02-07 15:46                               ` [PATCH v2 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc() Jiasheng Jiang
2025-02-06  5:25                     ` [PATCH 2/2] scsi: qedf: Add check for bdt_info Jiasheng Jiang
2025-02-06 11:56                     ` [PATCH v5? 0/2] scsi: qedf: Replace alloction API and add null check Markus Elfring
2025-02-05  2:01               ` [PATCH RESEND v3 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc() Jiasheng Jiang
2025-02-05  2:01                 ` [PATCH RESEND v3 2/2] scsi: qedf: Add check for bdt_info Jiasheng Jiang
2025-02-02 21:33       ` [PATCH v2] scsi: qedf: Use kcalloc() and add " Jiasheng Jiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbb46821-25dc-4f5d-a6bf-cbef34024afd@acm.org \
    --to=bvanassche@acm.org \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=arun.easi@cavium.com \
    --cc=jhasan@marvell.com \
    --cc=jiashengjiangcool@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manish.rangankar@cavium.com \
    --cc=martin.petersen@oracle.com \
    --cc=nilesh.javali@cavium.com \
    --cc=skashyap@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox