Re: [PATCH v10 1/4] tee: optee: system call property

kernel test robot
2023-10-04T01:48:18Z

Hi Etienne,

kernel test robot noticed the following build warnings:

[auto build test WARNING on soc/for-next]
[also build test WARNING on linus/master v6.6-rc4 next-20231003]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Etienne-Carriere/tee-optee-system-call-property/20231003-220916
base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
patch link: https://lore.kernel.org/r/20231003140637.31346-2-etienne.carriere%40foss.st.com
patch subject: [PATCH v10 1/4] tee: optee: system call property
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20231004/202310040951.IEVtCbbL-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231004/202310040951.IEVtCbbL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310040951.IEVtCbbL-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/tee/optee/ffa_abi.c:618: warning: Function parameter or member 'system_thread' not described in 'optee_ffa_do_call_with_arg'
--
drivers/tee/optee/smc_abi.c:818: warning: Function parameter or member 'rpc_arg' not described in 'optee_handle_rpc'
>> drivers/tee/optee/smc_abi.c:890: warning: Function parameter or member 'system_thread' not described in 'optee_smc_do_call_with_arg'

vim +618 drivers/tee/optee/ffa_abi.c

4615e5a34b95e0 Jens Wiklander 2021-07-21 602
4615e5a34b95e0 Jens Wiklander 2021-07-21 603 /**
4615e5a34b95e0 Jens Wiklander 2021-07-21 604 * optee_ffa_do_call_with_arg() - Do a FF-A call to enter OP-TEE in secure world
4615e5a34b95e0 Jens Wiklander 2021-07-21 605 * @ctx: calling context
4615e5a34b95e0 Jens Wiklander 2021-07-21 606 * @shm: shared memory holding the message to pass to secure world
5b4018b959149e Jens Wiklander 2022-01-25 607 * @offs: offset of the message in @shm
4615e5a34b95e0 Jens Wiklander 2021-07-21 608 *
4615e5a34b95e0 Jens Wiklander 2021-07-21 609 * Does a FF-A call to OP-TEE in secure world and handles eventual resulting
4615e5a34b95e0 Jens Wiklander 2021-07-21 610 * Remote Procedure Calls (RPC) from OP-TEE.
4615e5a34b95e0 Jens Wiklander 2021-07-21 611 *
4615e5a34b95e0 Jens Wiklander 2021-07-21 612 * Returns return code from FF-A, 0 is OK
4615e5a34b95e0 Jens Wiklander 2021-07-21 613 */
4615e5a34b95e0 Jens Wiklander 2021-07-21 614
4615e5a34b95e0 Jens Wiklander 2021-07-21 615 static int optee_ffa_do_call_with_arg(struct tee_context *ctx,
8f8e909e5204c3 Etienne Carriere 2023-10-03 616 struct tee_shm *shm, u_int offs,
8f8e909e5204c3 Etienne Carriere 2023-10-03 617 bool system_thread)
4615e5a34b95e0 Jens Wiklander 2021-07-21 @618 {
4615e5a34b95e0 Jens Wiklander 2021-07-21 619 struct ffa_send_direct_data data = {
4615e5a34b95e0 Jens Wiklander 2021-07-21 620 .data0 = OPTEE_FFA_YIELDING_CALL_WITH_ARG,
4615e5a34b95e0 Jens Wiklander 2021-07-21 621 .data1 = (u32)shm->sec_world_id,
4615e5a34b95e0 Jens Wiklander 2021-07-21 622 .data2 = (u32)(shm->sec_world_id >> 32),
5b4018b959149e Jens Wiklander 2022-01-25 623 .data3 = offs,
4615e5a34b95e0 Jens Wiklander 2021-07-21 624 };
4064c461148ab1 Jens Wiklander 2021-12-28 625 struct optee_msg_arg *arg;
4064c461148ab1 Jens Wiklander 2021-12-28 626 unsigned int rpc_arg_offs;
4064c461148ab1 Jens Wiklander 2021-12-28 627 struct optee_msg_arg *rpc_arg;
4064c461148ab1 Jens Wiklander 2021-12-28 628
a639b2b18a240d Jens Wiklander 2022-01-12 629 /*
a639b2b18a240d Jens Wiklander 2022-01-12 630 * The shared memory object has to start on a page when passed as
a639b2b18a240d Jens Wiklander 2022-01-12 631 * an argument struct. This is also what the shm pool allocator
a639b2b18a240d Jens Wiklander 2022-01-12 632 * returns, but check this before calling secure world to catch
a639b2b18a240d Jens Wiklander 2022-01-12 633 * eventual errors early in case something changes.
a639b2b18a240d Jens Wiklander 2022-01-12 634 */
a639b2b18a240d Jens Wiklander 2022-01-12 635 if (shm->offset)
a639b2b18a240d Jens Wiklander 2022-01-12 636 return -EINVAL;
a639b2b18a240d Jens Wiklander 2022-01-12 637
5b4018b959149e Jens Wiklander 2022-01-25 638 arg = tee_shm_get_va(shm, offs);
4064c461148ab1 Jens Wiklander 2021-12-28 639 if (IS_ERR(arg))
4064c461148ab1 Jens Wiklander 2021-12-28 640 return PTR_ERR(arg);
4064c461148ab1 Jens Wiklander 2021-12-28 641
4064c461148ab1 Jens Wiklander 2021-12-28 642 rpc_arg_offs = OPTEE_MSG_GET_ARG_SIZE(arg->num_params);
5b4018b959149e Jens Wiklander 2022-01-25 643 rpc_arg = tee_shm_get_va(shm, offs + rpc_arg_offs);
4064c461148ab1 Jens Wiklander 2021-12-28 644 if (IS_ERR(rpc_arg))
4064c461148ab1 Jens Wiklander 2021-12-28 645 return PTR_ERR(rpc_arg);
4615e5a34b95e0 Jens Wiklander 2021-07-21 646
8f8e909e5204c3 Etienne Carriere 2023-10-03 647 return optee_ffa_yielding_call(ctx, &data, rpc_arg, system_thread);
4615e5a34b95e0 Jens Wiklander 2021-07-21 648 }
4615e5a34b95e0 Jens Wiklander 2021-07-21 649

--
0-DAY CI Kernel Test Service