From: Konrad Dybcio <konradybcio@kernel.org>
To: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>,
konrad.dybcio@linaro.org, andersson@kernel.org,
andi.shyti@kernel.org, linux-arm-msm@vger.kernel.org,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, conor+dt@kernel.org,
agross@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org,
linux@treblig.org, dan.carpenter@linaro.org, Frank.Li@nxp.com,
konradybcio@kernel.org
Cc: quic_vdadhani@quicinc.com
Subject: Re: [PATCH v2 3/4] soc: qcom: geni-se: Export function geni_se_clks_off()
Date: Mon, 9 Sep 2024 13:35:13 +0200 [thread overview]
Message-ID: <bbdd95e3-9090-4952-beb5-ad52f2a3dcae@kernel.org> (raw)
In-Reply-To: <20240906191438.4104329-4-quic_msavaliy@quicinc.com>
On 6.09.2024 9:14 PM, Mukesh Kumar Savaliya wrote:
> Currently the driver provides a function called geni_serial_resources_off()
> to turn off resources like clocks and pinctrl. We don't have a function to
> control clocks separately hence, export the function geni_se_clks_off() to
> turn off clocks separately without disturbing GPIO.
>
> Client drivers like I2C require this function for use-cases where the I2C
> SE is shared between two subsystems.
>
> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
> ---
Well, i2c is probably not the only type of client you'll want
to share and the current approach requires changes in all protocol
drivers.
How about adding a parameter like `bool shared_se` to
geni_se_resources_off() and changing the pinctrl state conditionally?
Konrad
next prev parent reply other threads:[~2024-09-09 11:35 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 19:14 [PATCH v2 0/4] Enable shared SE support over I2C Mukesh Kumar Savaliya
2024-09-06 19:14 ` [PATCH v2 1/4] dt-bindindgs: i2c: qcom,i2c-geni: Document shared flag Mukesh Kumar Savaliya
2024-09-07 9:04 ` Krzysztof Kozlowski
2024-09-10 9:09 ` Mukesh Kumar Savaliya
2024-09-10 9:54 ` Krzysztof Kozlowski
2024-09-10 13:44 ` Mukesh Kumar Savaliya
2024-09-06 19:14 ` [PATCH v2 2/4] dma: gpi: Add Lock and Unlock TRE support to access SE exclusively Mukesh Kumar Savaliya
2024-09-06 19:14 ` [PATCH v2 3/4] soc: qcom: geni-se: Export function geni_se_clks_off() Mukesh Kumar Savaliya
2024-09-09 11:35 ` Konrad Dybcio [this message]
2024-09-10 9:11 ` Mukesh Kumar Savaliya
2024-09-06 19:14 ` [PATCH v2 4/4] i2c: i2c-qcom-geni: Enable i2c controller sharing between two subsystems Mukesh Kumar Savaliya
2024-09-07 7:56 ` Andi Shyti
2024-09-10 13:42 ` Mukesh Kumar Savaliya
2024-09-09 8:54 ` neil.armstrong
2024-09-09 9:18 ` Mukesh Kumar Savaliya
2024-09-09 11:37 ` Konrad Dybcio
2024-09-09 12:53 ` Andi Shyti
2024-09-10 13:39 ` Mukesh Kumar Savaliya
2024-09-10 9:12 ` Mukesh Kumar Savaliya
2024-09-09 13:04 ` neil.armstrong
2024-09-10 9:15 ` Mukesh Kumar Savaliya
2024-09-10 9:52 ` neil.armstrong
2024-09-18 12:20 ` Mukesh Kumar Savaliya
2024-09-10 9:12 ` Mukesh Kumar Savaliya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbdd95e3-9090-4952-beb5-ad52f2a3dcae@kernel.org \
--to=konradybcio@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox